Re: [RFC PATCH 0/2] GetRasterStatus: Needs to be tested on Windows

[Florian Köberle]

Sorry for the big attachment, didn't realize that crosstests executables
are so large.

[without attachment][RFC PATCH 0/2] GetRasterStatus: Needs to be tested on Windows

[Florian Köberle]

Hello

my first mail with the 1.4 MB attachment got luckily filtered by the mailinglist. This is a slightly modified version of it:

According to the MSDN GetRasterStatus should return D3DERR_INVALIDCALL
if the flag D3DCAPS_READ_SCANLINE isn't set [0].

I wrote a test which tests exactly that statement, but I am not sure if
I obtain the caps in the correct way.

I don't have a Windows system with Direct 3D available to test the
patch. I have attached the compiled crosstest to bug 23556 [1]. It would be interesting
to know which output the crosstest executable generates if it gets run
with the argument "device". The output could then be used to find out if
the test passed, failed or got skipped.

The second patch fixes bug 23556:
Starcraft 2 gets stuck in an infite loop at startup, if GetRasterStatus
does not return D3DERR_INVALIDCALL.
http://bugs.winehq.org/show_bug.cgi?id=23556

Best regards,
Florian



[0] http://msdn.microsoft.com/en-us/library/bb174402%28VS.85%29.aspx
[1] http://bugs.winehq.org/attachment.cgi?id=29647