Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.

[Vitaliy Margolen]

Lei Zhang wrote:
> Hi,
>
> On Windows, the Msi.Package action registry keys have the full path to
> msiexec.exe.
> ------------------------------------------------------------------------
>
> +HKCR,Msi.Package\shell\Open\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /i ""%1"" %*"
> +HKCR,Msi.Package\shell\Repair\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /f ""%1"" %*"
> +HKCR,Msi.Package\shell\Uninstall\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /x ""%1"" %*"

Should those 0x20002 be 0x20000 instead? Why do we need to preserve 
overrides of something that can be opened with msi only?

Vitaliy

[PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.

[Lei Zhang]

On Tue, Jul 29, 2008 at 8:19 PM, Vitaliy Margolen
<wine-devel(a)kievinfo.com> wrote:
> Lei Zhang wrote:
> > Hi,
> >
> > On Windows, the Msi.Package action registry keys have the full path to
> > msiexec.exe.
> > ------------------------------------------------------------------------
> >
> > +HKCR,Msi.Package\shell\Open\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /i ""%1"" %*"
> > +HKCR,Msi.Package\shell\Repair\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /f ""%1"" %*"
> > +HKCR,Msi.Package\shell\Uninstall\command,,0x20002,"""%SystemRoot%\System32\msiexec.exe"" /x ""%1"" %*"
>
> Should those 0x20002 be 0x20000 instead? Why do we need to preserve
> overrides of something that can be opened with msi only?

Sure, we would want users who upgraded Wine to get this in their
existing .wine directories. Unlike the registry key for $PATH, I
cannot imagine too many people would change this registry key. Will
resend patch in a bit.