Re: shell32 patches to be usable by ReactOS Explorer

[Alexandre Julliard]

"Martin Fuchs" <martin-fuchs(a)gmx.net> writes:
> This was no joke. If you say, you would accept such as reformating patch,
> I can easyly create one that eliminates all tab-characters, and generates
> nice and uniform indented code.
> This will make it a bit easier to create the small self-contained patches
> you want to see instead of the big one. As additional bonus you will get
> a very better formated shell32 code base.

There's no reason to reformat all of shell32. If a given function is
messed up you can fix it (in a separate patch), but otherwise it
doesn't really matter if all functions don't use the exact same style.

-- 
Alexandre Julliard
julliard(a)winehq.com

Source code formatting proposal (Was: Re: shell32 patches to be usable by ReactOS Explorer)

[Jakob Eriksson]

Alexandre Julliard wrote:
> There's no reason to reformat all of shell32. If a given function is
> messed up you can fix it (in a separate patch), but otherwise it
> doesn't really matter if all functions don't use the exact same style.

Proposal:
add source code formatting at check-in - with a twist.
The check-in script should only do the formatting if there is a comment 
in the header
of the source file, like so:

/* Allow-auto-indenting */


Those who consider themselves "maintainers" of a certain file can add 
this comment
to their patches and from then on the file will be auto-indented at 
check-in.


regards,
Jakob