Re: dmloader: Fix a possible null dereference

[Paul Vriens]

On 01/05/2010 02:18 PM, David Adam wrote:
> Hello
>
> This patch fixes the bug  13986
>
> A+
>
> David
> Searc

Hi David,

+    hr = CoInitialize(NULL);
+    if ( FAILED(hr) )
+    {
+        skip("CoInitializeEx failed.\n");
+        return;
+    }

The skip() message doesn't match the actual function called.

+    hr = CoCreateInstance(&CLSID_DirectMusicLoader, NULL, 
CLSCTX_INPROC, &IID_IDirectMusicLoader8, (void**)&loader);
+    if (FAILED(hr))
+    {
+        skip("CoCreateInstance failed.\n");
+	return;
+    }

Your mixing tabs and spaces here.

Shouldn't 'loader' be released on return?

-- 
Cheers,

Paul.