Re: [PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_ns.

[Nikolay Sivov]

On 28.03.2017 17:44, Jacek Caban wrote:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
>  dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------
>  1 file changed, 27 insertions(+), 6 deletions(-)

> +static struct ns default_ns = {
> +    { emptyW },
> +    { emptyW }
>  };

I think this could use a better name. Default namespace is something
defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match
empty strings naming.

Also everything static in this patch should be also const, no?

[PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_ns.

[Jacek Caban]

On 28.03.2017 16:54, Nikolay Sivov wrote:
> On 28.03.2017 17:44, Jacek Caban wrote:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > ---
> >  dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------
> >  1 file changed, 27 insertions(+), 6 deletions(-)
> > +static struct ns default_ns = {
> > +    { emptyW },
> > +    { emptyW }
> >  };
>
> I think this could use a better name. Default namespace is something
> defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match
> empty strings naming.

Sure, I will rename it.
> Also everything static in this patch should be also const, no?

Some of them, with additional changes, yes. I will send a new patch set.
Strings themselves can't be const for the same reason they are not const
in strval static variables.


Thanks,

Jacek