Re: setupapi: Implement installing catalog files

[Alexandre Julliard]

Maarten Lankhorst <maarten(a)codeweavers.com> writes:
> +        wintrust = LoadLibraryW(wintrust_dll);
> +        pCryptCATAdminAcquireContext = (void *)GetProcAddress(wintrust, "CryptCATAdminAcquireContext");
> +        pCryptCATAdminAddCatalog = (void *)GetProcAddress(wintrust, "CryptCATAdminAddCatalog");
> +        pCryptCATAdminReleaseCatalogContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseCatalogContext");
> +        pCryptCATAdminReleaseContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseContext");
> +        FreeLibrary(wintrust);

I doubt that calling functions in an unloaded library is going to give
good results...

-- 
Alexandre Julliard
julliard(a)winehq.org

setupapi: Implement installing catalog files

[Maarten Lankhorst]

Hi AJ,

Alexandre Julliard schreef:
> Maarten Lankhorst <maarten(a)codeweavers.com> writes:
> > +        wintrust = LoadLibraryW(wintrust_dll);
> > +        pCryptCATAdminAcquireContext = (void *)GetProcAddress(wintrust, "CryptCATAdminAcquireContext");
> > +        pCryptCATAdminAddCatalog = (void *)GetProcAddress(wintrust, "CryptCATAdminAddCatalog");
> > +        pCryptCATAdminReleaseCatalogContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseCatalogContext");
> > +        pCryptCATAdminReleaseContext = (void *)GetProcAddress(wintrust, "CryptCATAdminReleaseContext");
> > +        FreeLibrary(wintrust);
>
> I doubt that calling functions in an unloaded library is going to give
> good results...

Oops, thanks for catching that. Apparantly it somehow didn't complete 
crash for me. In the error paths I also found that I forgot to call the 
cleanup functions, so I'll send a revised patch.

Cheers,
Maarten.

setupapi: Implement installing catalog files

[Alexandre Julliard]

Maarten Lankhorst <maarten(a)codeweavers.com> writes:
> Oops, thanks for catching that. Apparantly it somehow didn't complete
> crash for me. In the error paths I also found that I forgot to call
> the cleanup functions, so I'll send a revised patch.

Actually you probably don't want to free the library at all. If there
are multiple files to install loading/unloading wintrust for each file
would be expensive.

-- 
Alexandre Julliard
julliard(a)winehq.org