Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.
Alexandre Julliard a écrit :
Module: wine Branch: master Commit: dcec342b50524562844f64d43d423ed2c83c1f97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d...
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 11 14:52:28 2009 +0100
user32: Add a thunking mechanism for 16-bit edit word break procedures.
Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)
Eric Pouech <eric.pouech(a)orange.fr> writes:
Alexandre Julliard a écrit :
Module: wine Branch: master Commit: dcec342b50524562844f64d43d423ed2c83c1f97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d...
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 11 14:52:28 2009 +0100
user32: Add a thunking mechanism for 16-bit edit word break procedures.
Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ?
No, the thunks are associated to a function, not to a window, so they never get freed. It's the same idea as for the winproc thunks. -- Alexandre Julliard julliard(a)winehq.org
Alexandre Julliard a écrit :
Eric Pouech <eric.pouech(a)orange.fr> writes:
Alexandre Julliard a écrit :
Module: wine Branch: master Commit: dcec342b50524562844f64d43d423ed2c83c1f97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d...
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Dec 11 14:52:28 2009 +0100
user32: Add a thunking mechanism for 16-bit edit word break procedures.
Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ?
No, the thunks are associated to a function, not to a window, so they never get freed. It's the same idea as for the winproc thunks.
do you recommend this way of doing being the recommanded way for all the thunks which have been recently added ie assuming the app will only provide a limited number of functions being passed to the thunks, rather than trying to allocate/free the thunks when possible ? -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)
Eric Pouech <eric.pouech(a)orange.fr> writes:
do you recommend this way of doing being the recommanded way for all the thunks which have been recently added ie assuming the app will only provide a limited number of functions being passed to the thunks, rather than trying to allocate/free the thunks when possible ?
Yes, it makes things simpler, but it only works if the thunks don't need to store any extra information, so it may not apply everywhere. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Eric Pouech