Re: [PATCH] wined3d: Add NVIDIA GTX 675MX to the GPU list.

[Henri Verbeet]

On 24 September 2016 at 00:00, Filip Frąckiewicz
<fjfrackiewicz(a)gmail.com> wrote:
> -    {"NVE4",                        CARD_NVIDIA_GEFORCE_GTX680},    /* 690 */
> +    {"NVE4",                        CARD_NVIDIA_GEFORCE_GTX680},    /* 690 / 675MX */
> It's not wrong, but I don't think this is very useful. In general
> what's essentially the same GPU is available under many different
> names and PCI IDs, and the wined3d source code isn't the best place to
> document those.

[PATCH] wined3d: Add NVIDIA GTX 675MX to the GPU list.

[Filip Frackiewicz]

Understood. I was following the other examples in the code but I will
follow your advice for future patches. Thanks again!

On Mon, Sep 26, 2016 at 1:30 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 24 September 2016 at 00:00, Filip Frąckiewicz
> <fjfrackiewicz(a)gmail.com> wrote:
> > -    {"NVE4",                        CARD_NVIDIA_GEFORCE_GTX680},    /* 690 */
> > +    {"NVE4",                        CARD_NVIDIA_GEFORCE_GTX680},    /* 690 / 675MX */
> > It's not wrong, but I don't think this is very useful. In general
> > what's essentially the same GPU is available under many different
> > names and PCI IDs, and the wined3d source code isn't the best place to
> > document those.