The 'file' regression test fails on NT
I tested the 'file' regression test on NT4 and XP and it fails on both. Here is where the error occurs: tests/file.c:236: Test failed: DeleteFile failed (5). tests/file.c:240: Test failed: couldn't create file "testfile.xxx" (err=5) tests/file.c:242: Test failed: _hwrite complains. [...] 5 means 'permission denied'. DeleteFile fails just after _lcreat(filename,1) creates a read-only file: H:\wine\wine\dlls\kernel>attrib testfile.xxx A R H:\wine\wine\dlls\kernel\testfile.xxx Because that file is marked read-only, DeleteFile fails to delete it, then causing the failure of all the other tests. I checked and the same happens on non-smb drives (c:\). I also checked that the exact same thing happens on Windows 98. So the test needs to be fixed. Jakob, can you do this? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.
"Francois" == Francois Gouget <fgouget(a)free.fr> writes:
Francois> I tested the 'file' regression test on NT4 and XP and it fails Francois> on both. Here is where the error occurs: Francois> tests/file.c:236: Test failed: DeleteFile failed (5). Francois> tests/file.c:240: Test failed: couldn't create file Francois> "testfile.xxx" (err=5) tests/file.c:242: Test failed: _hwrite Francois> complains. [...] Francois> 5 means 'permission denied'. DeleteFile fails just after Francois> _lcreat(filename,1) creates a read-only file: Francois> H:\wine\wine\dlls\kernel>attrib testfile.xxx A R Francois> H:\wine\wine\dlls\kernel\testfile.xxx Francois> Because that file is marked read-only, DeleteFile fails to Francois> delete it, then causing the failure of all the other tests. I Francois> checked and the same happens on non-smb drives (c:\). I also Francois> checked that the exact same thing happens on Windows 98. Francois> So the test needs to be fixed. Jakob, can you do this? I sent a patch "Check sharing in DeleteFile"(2)/"Test for DeleteFile"(1) on May 9 which worked in that area. (2) should be applied after (1). Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
On Tue, 21 May 2002, Uwe Bonnes wrote: [...]
Francois> Because that file is marked read-only, DeleteFile fails to Francois> delete it, then causing the failure of all the other tests. I Francois> checked and the same happens on non-smb drives (c:\). I also Francois> checked that the exact same thing happens on Windows 98.
Francois> So the test needs to be fixed. Jakob, can you do this?
I sent a patch "Check sharing in DeleteFile"(2)/"Test for DeleteFile"(1) on May 9 which worked in that area. (2) should be applied after (1).
Yes, these both look good. The test patch can even be applied before the DeleteFile patch. What counts is that the test works on Windows. Then we know exactly what to fix in Wine. I would move the initial SetFileAttributesA and DeleteFileA to the START_TEST(file) function. And it will just need to be adapted to apply after my patch :-) Can someone do this? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY
On Tue, May 21, 2002 at 12:34:11AM -0700, Francois Gouget wrote:
On Tue, 21 May 2002, Uwe Bonnes wrote: [...]
Francois> Because that file is marked read-only, DeleteFile fails to Francois> delete it, then causing the failure of all the other tests. I Francois> checked and the same happens on non-smb drives (c:\). I also Francois> checked that the exact same thing happens on Windows 98.
Francois> So the test needs to be fixed. Jakob, can you do this?
I sent a patch "Check sharing in DeleteFile"(2)/"Test for DeleteFile"(1) on May 9 which worked in that area. (2) should be applied after (1).
Yes, these both look good. The test patch can even be applied before the DeleteFile patch. What counts is that the test works on Windows. Then we know exactly what to fix in Wine.
I would move the initial SetFileAttributesA and DeleteFileA to the START_TEST(file) function. And it will just need to be adapted to apply after my patch :-) Can someone do this?
I'll see what's up. -- regards, Jakob Eriksson The wages of sin is debugging. -- Ron Jeffries
On Mon, May 20, 2002 at 05:57:27PM -0700, Francois Gouget wrote:
I tested the 'file' regression test on NT4 and XP and it fails on both. Here is where the error occurs:
tests/file.c:236: Test failed: DeleteFile failed (5). tests/file.c:240: Test failed: couldn't create file "testfile.xxx" (err=5) tests/file.c:242: Test failed: _hwrite complains. [...]
5 means 'permission denied'. DeleteFile fails just after _lcreat(filename,1) creates a read-only file:
H:\wine\wine\dlls\kernel>attrib testfile.xxx A R H:\wine\wine\dlls\kernel\testfile.xxx
Because that file is marked read-only, DeleteFile fails to delete it, then causing the failure of all the other tests. I checked and the same happens on non-smb drives (c:\). I also checked that the exact same thing happens on Windows 98.
So the test needs to be fixed. Jakob, can you do this?
The test is fixed now, patch sent to wine-patches. I compiled file.c with: i586-mingw32msvc-gcc -DREAL_EXE -o file.exe file.c and ran file.exe on Windows 95B to verify. So now the tests pass but one "todo_wine{}" on Wine and all of them pass on Windows 95B. -- regards, Jakob Eriksson The wages of sin is debugging. -- Ron Jeffries
participants (3)
-
Francois Gouget -
Jakob Eriksson -
Uwe Bonnes