Re: [2/2] shell32/autocomplete: add unit tests for autocomplete

[Paul Vriens]

Jan de Mooij wrote:
> Tests pass on 98, XP and Wine (after applying my previous patch)
>
> ------------------------------------------------------------------------

There is an unrelated change to shelllink.c in this patch.

-- 
Cheers,

Paul.

[2/2] shell32/autocomplete: add unit tests for autocomplete

[Jan de Mooij]

Hi Paul,

Thanks for your reply.

On Mon, Dec 1, 2008 at 3:35 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> There is an unrelated change to shelllink.c in this patch.

It's not unrelated, initguid.h needs to be included exactly once or
you will get linker warnings (multiple definitions for...).
It only compiles if i move it to autocomplete.c, looks like it should
be in the first file which uses it..

Regards,

Jan de Mooij

[2/2] shell32/autocomplete: add unit tests for autocomplete

[Paul Vriens]

Jan de Mooij wrote:
> Hi Paul,
>
> Thanks for your reply.
>
> On Mon, Dec 1, 2008 at 3:35 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> > There is an unrelated change to shelllink.c in this patch.
>
> It's not unrelated, initguid.h needs to be included exactly once or
> you will get linker warnings (multiple definitions for...).
> It only compiles if i move it to autocomplete.c, looks like it should
> be in the first file which uses it..
>
> Regards,
>
> Jan de Mooij

But I guess that's the reason it's not applied/committed. If you move the 
include of initguid.h to after windows.h it will work, not?

-- 
Cheers,

Paul.