Re: [PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

[Henri Verbeet]

On 1 December 2011 11:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> An IDirect3DDevice3 test will follow once the d3d initialization design has
> been approved.

If we're going to redo the way the tests work anyway, we probably
shouldn't reuse the same objects for everything either.

[PATCH 3/3] ddraw/tests: Add a IDirect3DDevice2 GetCaps test

[Stefan Dösinger]

Am Donnerstag, 1. Dezember 2011, 15:15:23 schrieb Henri Verbeet:
> If we're going to redo the way the tests work anyway, we probably
> shouldn't reuse the same objects for everything either.
> You mean reinitialize ddraw/d3d for every test? I'm not sure if that's a good 
> idea(or enough, depending on how you look at it). At least one of my Windows 
> machine(The radeon X1600 one) has occasional test failures in the ddraw visual 
> tests that occur right after d3d7 has been unloaded and d3d1 started. I 
> suspect it is a race condition somewhere in the d3d init and shutdown 
> functions(All I see is that the problems go away if I don't run the d3d7 tests 
> first).

Maybe spawning a new process for every test would work. I'm not sure if we can 
or want to do that. In either case we don't want to use fullscreen mode if we 
reinitialize d3d for every test. That's an issue for the visual tests, the d3d 
ones are windowed anyway(Except those that explicitly test mode switches)