RE: shell32: SHChangeNotify is really Unicode/ANSI indifferent

[Robert Shearman]

> From: "Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl>
> To: <wine-patches(a)winehq.com>
> Subject: shell32: SHChangeNotify is really Unicode/ANSI indifferent
> Date: Mon, 20 Jan 2003 21:53:34 +0100
> Reply-To: wine-devel(a)winehq.com

<snip>
> -/****************************************************************
> *********
> - * SHChangeNotify				[SHELL32.@]
> - */
> -void WINAPI SHChangeNotifyA (LONG wEventId, UINT  uFlags,
> LPCVOID dwItem1, LPCVOID dwItem2)
> +void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID
> dwItem1, LPCVOID dwItem2)

<snip>
> +	else if (uFlags & SHCNF_PATHW)
> +	{
> +	  DWORD dummy;
> +	  if (dwItem1) SHILCreateFromPathW((LPCSTR)dwItem1,
> &Pidls[0], &dummy);
> +	  if (dwItem2) SHILCreateFromPathW((LPCSTR)dwItem2,
> &Pidls[1], &dummy);
> +	}
> +	else if (uFlags & (SHCNF_PRINTERW || SHCNF_PRINTERW)

There seems to be something strange with the line above (SHCNF_PRINTERW ||
SHCNF_PRINTERW) == SHCNF_PRINTERW. Should this be (SHCNF_PRINTERW ||
SHCNF_PRINTERA) by any chance?
> +	{
> +	  FIXME("SHChangeNotify with (uFlags & SHCNF_PRINTER)");
>   }

Other than that, good work!

Rob

shell32: SHChangeNotify is really Unicode/ANSI indifferent

[Francois Gouget]

On Mon, 20 Jan 2003, Robert Shearman wrote:
[...]
> > +	else if (uFlags & (SHCNF_PRINTERW || SHCNF_PRINTERW)
>
> There seems to be something strange with the line above (SHCNF_PRINTERW ||
> SHCNF_PRINTERW) == SHCNF_PRINTERW. Should this be (SHCNF_PRINTERW ||
> SHCNF_PRINTERA) by any chance?

And probably '||' should be a '|':

else if (uFlags & (SHCNF_PRINTERA | SHCNF_PRINTERW) ==
                  (SHCNF_PRINTERA | SHCNF_PRINTERW))


-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
            Before you criticize someone, walk a mile in his shoes.
       That way, if he gets angry, he'll be a mile away - and barefoot.