Re: [wined3d] color fill

[Alexandre Julliard]

Oliver Stieber <oliver_stieber(a)yahoo.co.uk> writes:
> Hi,
>      This patch implements IWineD3Device_ColorFill,
> the fr-30 candytron demo (
> http://www.scene.org/file.php?file=/demos/groups/farb-rausch/fr-030_candytro...
> ) makes use of this function.

I get a warning with this patch:

device.c:5013: warning: suggest parentheses around && within ||

and it isn't clear to me what you are trying to do here. The whole
handling of the container variable looks suspicious, at some places
you check it against NULL even though it has already been
dereferenced, and it's not released properly, so it looks like the
warning is a symptom of a deeper problem with that function.

-- 
Alexandre Julliard
julliard(a)winehq.org