Re: [PATCH 3/5] d3d9/tests: Add style and size tests for D3DCREATE_NOWINDOWCHANGES.

[Henri Verbeet]

On 16 October 2014 17:07, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> diff --git a/dlls/d3d9/tests/d3d9ex.c b/dlls/d3d9/tests/d3d9ex.c
> index 11fe091..34b967a 100644
> --- a/dlls/d3d9/tests/d3d9ex.c
> +++ b/dlls/d3d9/tests/d3d9ex.c
> @@ -37,6 +37,7 @@ struct device_desc
>      unsigned int width;
>      unsigned int height;
>      BOOL windowed;
> +    DWORD behavior_flags;
>  };

I don't like this much, I'd probably prefer "windowed" and
"behavior_flags" to be merged into a single flags field and then have
flags along the lines of e.g. CREATE_DEVICE_FULLSCREEN,
CREATE_DEVICE_NOWINDOWCHANGES, CREATE_DEVICE_SWVP_ONLY, etc.

[PATCH 3/5] d3d9/tests: Add style and size tests for D3DCREATE_NOWINDOWCHANGES.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-17 08:46, schrieb Henri Verbeet:
> I don't like this much, I'd probably prefer "windowed" and 
> "behavior_flags" to be merged into a single flags field and then
> have flags along the lines of e.g. CREATE_DEVICE_FULLSCREEN, 
> CREATE_DEVICE_NOWINDOWCHANGES, CREATE_DEVICE_SWVP_ONLY, etc.
> The negative side effect of that is that tests that test
> D3DCREATE_NOWINDOWCHANGES don't spell out the name
> D3DCREATE_NOWINDOWCHANGES, making a search if we have any tests for
> that more difficult. I'll send patches with this change, pick
> whichever you like better.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUQQozAAoJEN0/YqbEcdMwaBEQAIbh2lks760klSn1UmdrptJ1
Fr4ZDv2C2/+oIlXfxQwqh/TEQib1aVjYGDf03g+1TO6f8UCk7MrQ8+YwOmj+xhlB
riHoU5z1wsZRfWIzeitWxkAsDZ3cL//sicdm5TguXlJfQm1FNY7DZ0lu9vCARPvA
CA8lhIbh7k4Idd0a0wEof6Bv8fY7XDtSMwLCuySA7sLovqnoB9a30ymol6ImjvFA
fw8MCMJE+QSraK60fvs0/1wcS4vHw4oUMTvBTKDATsjvy+EL1axpxCHVVQA+dhQN
xXaUJNPuErRkJhsbSTwIDwuFI8eEGEN+hq9v03NIVezu+l2s0YfkbDacDT29aSGX
UrxPYXfFTZrWA0zjxGBeWax/qP8SDJdfy7NttaUnFoMW6558FaA/rKA7q5EgLtWg
li5Gny0l+C7jR/hti/j7BWge32YXmf/gLfMucV0eYP/zVppSoSxsTjA0K+ThlbA/
udXJynIsBWHODq0K10zaaItHapHH9h28E9j5Q76nLpGzGbR32PbfqOrbOfVgsaQe
kmJ/YTO8SrC97GUOXirwn3V4rS18oO21Q4iQIghaTGKbRBybaCbzetXBVXgDk54e
TN1S8fux4b8UmdzOrxyxscijfxOOxrddLZPqtJBM9B7JaBtVHEJf064yXNpZiary
60tlaLuKxNb5HZhbBMV2
=0cJv
-----END PGP SIGNATURE-----