Re: [PATCH 4/6] user32: Fix the calculation of system metrics icon sizes.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=30703

Your paranoid android.


=== wxppro (32 bit sysparams) ===
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20

=== wvistau64 (32 bit sysparams) ===
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18

=== w7u (32 bit sysparams) ===
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 6
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 6

=== w8 (32 bit sysparams) ===
sysparams.c:2517: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out
sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16

=== w1064 (32 bit sysparams) ===
sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message
sysparams.c:2523: Test failed: WM_DISPLAYCHANGE was sent with wParam 32 despite mode change failure
sysparams.c:2528: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1
sysparams.c:204: Test failed: Unexpected WM_DISPLAYCHANGE message
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16

=== wvistau64 (64 bit sysparams) ===
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 18
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 18

=== w1064 (64 bit sysparams) ===
sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 4 actual 16
sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 4 actual 16

[PATCH 4/6] user32: Fix the calculation of system metrics icon sizes.

[Huw Davies]

> On 2 May 2017, at 12:02, Marvin <testbot(a)winehq.org> wrote:
>
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> https://testbot.winehq.org/JobDetails.pl?Key=30703
>
> Your paranoid android.
>
> === wxppro (32 bit sysparams) ===
> sysparams.c:2825: Test failed: GetSystemMetrics(SM_CXSMICON): expected 16 actual 20
> sysparams.c:2826: Test failed: GetSystemMetrics(SM_CYSMICON): expected 16 actual 20

Sorry about that.  Probably best to hold this whole series while I get these sorted.

Huw.