Re: [PATCH 4/4] ole32: Support reading and writing custom clipformats in the data cache.

[Mike McCormack]

Robert Shearman wrote:
> +    {
> +        char *format_name = HeapAlloc(GetProcessHeap(), 0, length);
> +        if (!format_name)
> +            return E_OUTOFMEMORY;
> +        GetClipboardFormatNameA(clipformat, format_name, length);
> +        hr = IStream_Write(stream, format_name, length, NULL);
> +    }

You might want to free format_name at the end of that block.

Mike

[PATCH 4/4] ole32: Support reading and writing custom clipformats in the data cache.

[Robert Shearman]

Mike McCormack wrote:
> Robert Shearman wrote:
> > +    {
> > +        char *format_name = HeapAlloc(GetProcessHeap(), 0, length);
> > +        if (!format_name)
> > +            return E_OUTOFMEMORY;
> > +        GetClipboardFormatNameA(clipformat, format_name, length);
> > +        hr = IStream_Write(stream, format_name, length, NULL);
> > +    }
>
> You might want to free format_name at the end of that block.

Thanks for spotting this. I've sent an updated patch.

-- 
Rob Shearman