Re: [PATCH 1/6] d3d9: Retrieve the volume description from the container.

[Henri Verbeet]

On 17 April 2014 15:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> ---
>  dlls/d3d9/texture.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

I suppose this works, but I don't think it's really necessary. At some
point wined3d_texture_get_sub_resource() will go away of course, but I
don't think there's a reason we can't e.g. have a
wined3d_resource_get_sub_resource_desc(), or alternatively just store
the information on d3d9 volume creation.

[PATCH 1/6] d3d9: Retrieve the volume description from the container.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-04-18 13:08, schrieb Henri Verbeet:
> On 17 April 2014 15:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> > ---
> >  dlls/d3d9/texture.c | 20 +++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
>
> I suppose this works, but I don't think it's really necessary. At some
> point wined3d_texture_get_sub_resource() will go away of course, but I
> don't think there's a reason we can't e.g. have a
> wined3d_resource_get_sub_resource_desc(), or alternatively just store
> the information on d3d9 volume creation.
> Both of those alternatives work, but I'd prefer not to expose sub resources more than necessary. Map and get_dc need access to sub resources, but the rest of the information can be retrieved from the container.

I'm not convinced that storing the size at creation is better either. Consider that surfaces can have their size changed by reset calls.

That's not a strong opinion though, if you have a reason to prefer one of your suggestions I'm happy to change my plans.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTUVBbAAoJEN0/YqbEcdMwB1gQAJAequifOmY6HVgFhoIU2Xlw
0rltpGBXCKr9c64SXW4LiKPdNbGkHtWvxto5IZ1tFSpvbWeqbqYIsPhbLQZS02FD
MhgbfjLKADcaEqSBH7h6cc3rIEnrIfaX9uYZZN50CkU31kqxLQiD5qeoHGTkG0Rw
wAduomcPZ11CsbQSS0BTDR4ZoK2IthbyB48v2t2nZCvvng99aPP8LoDYHSGchiqh
SGIWJV9jx6ExKD7KvZxBsk1Y65x4VeVtIx2lq9WijUsKVh7pNGAbrxtBXScDnL59
NWqstI+Oy65/HC37MMKIYQJlrdqnvZcfWGo/WyaN7hKIb7LaCeNidxvD/czhDEkZ
eUW0v+rKT450HgAp/mkJdGi1JC0moebvDFFKESIx4FX3wIqqT2J21Ilw0C0lZs5D
Phc5sPI08mD/iFDCVqgOgyquVzWorfOg2soiwzwsdjn3X1KKLd/cIBp8I37ngsCn
nuklQPMAn+0x3enN1R9cdKmUJincb1bDhaZhDYEmnC3UJDvr2NOepmq0bEdxwaJX
dCsADA+vP4lOFrVtLE8M8J7iNXrjvBpF2jEqmWK0oj//Gxt+83/OPS4kUMCV6ong
G5A4ZHTXl3K8ksUVOyeEpL9ETUITeOgIQh4V/QxQJKLVgeN7B4RaI2j3kXccNJle
DuZt18UkVlg/zVuBVXq9
=u6/y
-----END PGP SIGNATURE-----