Re: [2/2] shlwapi: Implement SHFormatDateTimeA/SHFormatDateTimeW with tests
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay, This one introduces failures on what appears Vista+ : http://test.winehq.org/data/tests/shlwapi:ordinal.html Could you have a look? -- Cheers, Paul.
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi, Paul. It looks like it adds some special characters on new versions. I'll take a look. It could be LTR markers (I never saw them before though, only read about). Also I suspect problems with formatting, but for now we could wait for reports.
On 1 March 2010 17:39, Nikolay Sivov <bunglehead(a)gmail.com> wrote:
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi, Paul.
It looks like it adds some special characters on new versions. I'll take a look. It could be LTR markers (I never saw them before though, only read about). Also I suspect problems with formatting, but for now we could wait for reports.
Isn't it locale dependent? That is, you are passing LOCALE_USER_DEFAULT, so it will use the settings from the "Regional and Language Settings" on Windows (e.g. Japanese date format -- "2010年3月2日", or user-specified). Specifying an English LCID should work, but may fail if the user has entered a custom format containing special characters, so could still fail, It may also fail if English is not available. Also, it might be useful to change the code page to a UTF-8 code page so that the SHFormatDateTimeA calls return UTF-8 strings and as a result, we can see what the characters are (if this is possible). - Reece
On 3/2/2010 21:13, Reece Dunn wrote:
On 1 March 2010 17:39, Nikolay Sivov<bunglehead(a)gmail.com> wrote:
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi, Paul.
It looks like it adds some special characters on new versions. I'll take a look. It could be LTR markers (I never saw them before though, only read about). Also I suspect problems with formatting, but for now we could wait for reports.
Isn't it locale dependent? That is, you are passing LOCALE_USER_DEFAULT, so it will use the settings from the "Regional and Language Settings" on Windows (e.g. Japanese date format -- "2010年3月2日", or user-specified).
Yes, it's dependent of course, that's why I'm calling GetDateFormat with that locale specifier. And I expect whatever defined in locale data, available with -A call as well. For example I don't think Japanese fails to get -A format even with specific characters defined, that's what WideCharToMultiByte is for.
Specifying an English LCID should work, but may fail if the user has entered a custom format containing special characters, so could still fail, It may also fail if English is not available.
I don't want to silence test failures actually, I'm going to run additional test on failing boxes with testbot soon.
Also, it might be useful to change the code page to a UTF-8 code page so that the SHFormatDateTimeA calls return UTF-8 strings and as a result, we can see what the characters are (if this is possible).
SHFormatDateTimeA doesn't return UTF-8 of course. I suspect special formatting characters.
- Reece
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi again. Just thought maybe you have an idea what's going on with it. I just checked and it's definitely '?' 3f returned, and the problem is in A-call only. Locale data is fine, cause we have some Dutch boxes as you can see.
On 03/05/2010 11:16 AM, Nikolay Sivov wrote:
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi again.
Just thought maybe you have an idea what's going on with it. I just checked and it's definitely '?' 3f returned, and the problem is in A-call only. Locale data is fine, cause we have some Dutch boxes as you can see.
Maybe MS is actually serious with the comment about GetTimeFormat (http://msdn.microsoft.com/en-us/library/dd318130%28VS.85%29.aspx) being deprecated. Did you try GetTimeFormatEx on Vista+ ? -- Cheers, Paul.
On 3/5/2010 13:53, Paul Vriens wrote:
On 03/05/2010 11:16 AM, Nikolay Sivov wrote:
On 3/1/2010 20:01, Paul Vriens wrote:
On 03/01/2010 12:56 AM, Nikolay Sivov wrote:
Implement SHFormatDateTimeA/SHFormatDateTimeW with tests.
Spotted in logs while testing IE6.
Hi Nikolay,
This one introduces failures on what appears Vista+ :
http://test.winehq.org/data/tests/shlwapi:ordinal.html
Could you have a look?
Hi again.
Just thought maybe you have an idea what's going on with it. I just checked and it's definitely '?' 3f returned, and the problem is in A-call only. Locale data is fine, cause we have some Dutch boxes as you can see.
Maybe MS is actually serious with the comment about GetTimeFormat (http://msdn.microsoft.com/en-us/library/dd318130%28VS.85%29.aspx) being deprecated.
Did you try GetTimeFormatEx on Vista+ ?
When the ANSI version of this function is used with a Unicode-only locale identifier, the function can succeed because the operating system uses the system code page. However, characters that are undefined in the system code page appear in the string as a question mark (?).
This is it, I'll try.
participants (3)
-
Nikolay Sivov -
Paul Vriens -
Reece Dunn