Re: server: Only commit SetThreadPriority if new priority is correct (try 2)
Matt Jones wrote:
+ if ((req->priority >= min || + req->priority == THREAD_PRIORITY_IDLE) || + (req->priority <= max || + req->priority == THREAD_PRIORITY_TIME_CRITICAL)) + thread->priority = req->priority; + }
This doesn't look correct. There should be an && in there instead of one of the || operators. -- Rob Shearman
Ok - I was using DWORD instead of int for min & max which made them unsigned. I've corrected that now and attached an updated version of both patches (also corrected my email address in the patch) Thanks, Matt On 7/19/07, Robert Shearman <rob(a)codeweavers.com> wrote:
Matt Jones wrote:
+ if ((req->priority >= min || + req->priority == THREAD_PRIORITY_IDLE) || + (req->priority <= max || + req->priority == THREAD_PRIORITY_TIME_CRITICAL)) + thread->priority = req->priority; + }
This doesn't look correct. There should be an && in there instead of one of the || operators.
-- Rob Shearman
participants (2)
-
Matt Jones -
Robert Shearman