Re: [PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall

[Dmitry Timoshkov]

Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote:
> -IMPORTS   = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32
> +IMPORTS   = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi
> ...
> +#include <shlwapi.h>
> ...
> -            info->regroot = root;
> +            info->regroot = SHRegDuplicateHKey(root);

Adding a whole new import just because of a simple RegOpenKeyEx() wrapper
is not really justified.

-- 
Dmitry.

[PATCH] appwiz.cpl: Remove list entries left over from an earlier uninstall

[Hugh McMaster]

On Thursday, 15 December 2016 11:47 PM, Dmitry Timoshkov wrote:
> Hugh McMaster wrote:
> > -IMPORTS   = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32
> > +IMPORTS   = uuid urlmon advpack comctl32 advapi32 shell32 ole32 user32 comdlg32 shlwapi
> > ...
> > +#include <shlwapi.h>
> > ...
> > -            info->regroot = root;
> > +            info->regroot = SHRegDuplicateHKey(root);
>
> Adding a whole new import just because of a simple RegOpenKeyEx() wrapper
> is not really justified.

I never thought to check what SHRegDuplicateHKey() actually did.

Thanks for the feedback. I'll send an updated patch tomorrow.

--
Hugh