Re: [PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> +static inline ULONG get_refcount(IUnknown *iface)
> +{
> +    ULONG ref = IUnknown_AddRef(iface);
> +    IUnknown_Release(iface);
> +    return ref;
> +}

This implementation may lead to wrong conclusions.

-- 
Dmitry.

[PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection

[Nikolay Sivov]

On 1/3/2014 14:25, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > +static inline ULONG get_refcount(IUnknown *iface)
> > +{
> > +    ULONG ref = IUnknown_AddRef(iface);
> > +    IUnknown_Release(iface);
> > +    return ref;
> > +}
> > This implementation may lead to wrong conclusions.

What you mean?

[PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection

[Dmitry Timoshkov]

Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > > +static inline ULONG get_refcount(IUnknown *iface)
> > > +{
> > > +    ULONG ref = IUnknown_AddRef(iface);
> > > +    IUnknown_Release(iface);
> > > +    return ref;
> > > +}
> > > This implementation may lead to wrong conclusions.
>
> What you mean?

It doesn't do what its name suggests.

-- 
Dmitry.

[PATCH 4/5] scrrun: Implement IEnumVARIANT stub for folder collection

[Nikolay Sivov]

On 1/3/2014 16:03, Dmitry Timoshkov wrote:
> Nikolay Sivov <nsivov(a)codeweavers.com> wrote:
> > > > +static inline ULONG get_refcount(IUnknown *iface)
> > > > +{
> > > > +    ULONG ref = IUnknown_AddRef(iface);
> > > > +    IUnknown_Release(iface);
> > > > +    return ref;
> > > > +}
> > > > This implementation may lead to wrong conclusions.
> >
> > What you mean?
> > It doesn't do what its name suggests.

Ah, ok.