Calling convention (__stdcall/__cdecl) mismatches between windef.h and crtdefs.h

[Bob Ha]

Hi,
It seems crtdefs.h uses older #ifdef checks.Depending on the inclusion order, crtdefs.h's one is being used, e.g. for msvcp*.dll's
windef.h
#   if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2)) || defined(__APPLE__)
crtdefs.h#   ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */

Is this something needed to be modified?
Cheers !

Bob

[Alexandre Julliard]

Bob Ha <bobha000(a)yahoo.com> writes:
> Hi,
>
> It seems crtdefs.h uses older #ifdef checks.
> Depending on the inclusion order, crtdefs.h's one is being used, e.g.
> for msvcp*.dll's
>
> windef.h
> # if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2)) ||
> defined(__APPLE__)
>
> crtdefs.h
> # ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a
> 4-byte one */
>
> Is this something needed to be modified?

Yes, this should be updated.

-- 
Alexandre Julliard
julliard(a)winehq.org