[PATCH] user32/tests: Add ClipCursor / focus interactions tests.
This is to confirm the behaviour of SetForegroundWindow and other focus switching methods w.r.t. the active ClipCursor rect. Depending on the method used to switch windows, the ClipCursor rect may be reset or not. Alt-Tab seems to reset it most of the time, but not on all windows versions. Other methods like closing windows, or calling SetForegroundWindow usually do not. MSDN says the applications should release the cursor when losing the focus, and, as windows doesn't seem very consistent, we will assume that they do. Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- dlls/user32/tests/input.c | 215 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 215 insertions(+) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index d0dc4a8bcf3..e22a0b0ad22 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -2862,6 +2862,219 @@ static void test_GetPointerType(void) ok(type == PT_MOUSE, " type %d\n", type ); } +static int clip_on_deactivate = 0; +static int clip_skip_cleanup = 0; +static int clip_default_cleanup = 0; +static RECT clip_rect = { 0, 0, 1, 1 }; + +static LRESULT WINAPI clip_cursor_wndproc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) +{ + + if (msg != WM_ACTIVATE) + return DefWindowProcA( hwnd, msg, wparam, lparam ); + + if (wparam != WA_INACTIVE) + { + ClipCursor( &clip_rect ); + } + else + { + if (clip_on_deactivate) + ClipCursor( &clip_rect ); + + if (clip_on_deactivate || clip_skip_cleanup) + return 0; + + if (clip_default_cleanup) + return DefWindowProcA( hwnd, msg, wparam, lparam ); + + ClipCursor( NULL ); + } + + return 0; +} + +static void send_alt_tab(void) +{ + keybd_event( VK_MENU, 0xb8, 0, 0 ); + Sleep( 100 ); + empty_message_queue(); + + keybd_event( VK_TAB, 0x8f, 0, 0 ); + Sleep( 100 ); + empty_message_queue(); + + keybd_event( VK_TAB, 0x8f, KEYEVENTF_KEYUP, 0 ); + Sleep( 100 ); + empty_message_queue(); + + keybd_event( VK_MENU, 0xb8, KEYEVENTF_KEYUP, 0 ); + Sleep( 100 ); + empty_message_queue(); +} + +static void test_ClipCursor(void) +{ + WNDCLASSA cls; + HWND hwnd, clip_hwnd; + RECT rect, screen_rect; + BOOL ret; + + cls.style = 0; + cls.lpfnWndProc = clip_cursor_wndproc; + cls.cbClsExtra = 0; + cls.cbWndExtra = 0; + cls.hInstance = GetModuleHandleA( 0 ); + cls.hIcon = 0; + cls.hCursor = LoadCursorW( NULL, (LPCWSTR)IDC_ARROW ); + cls.hbrBackground = (HBRUSH)(COLOR_WINDOW + 1); + cls.lpszMenuName = NULL; + cls.lpszClassName = "ClipCursorClass"; + if (!RegisterClassA( &cls )) return; + + ret = ClipCursor( NULL ); + ok( ret, "ClipCursor failed.\n" ); + ret = GetClipCursor( &screen_rect ); + ok( ret, "GetClipCursor failed.\n" ); + + + hwnd = CreateWindowA( "static", NULL, WS_OVERLAPPEDWINDOW | WS_VISIBLE, + 0, 0, 100, 100, NULL, NULL, NULL, NULL ); + ok( hwnd != NULL, "CreateWindowA failed, GetLastError(): %x.\n", GetLastError() ); + ShowWindow( hwnd, SW_SHOW ); + empty_message_queue(); + + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &screen_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + + + clip_hwnd = CreateWindowA( cls.lpszClassName, NULL, WS_OVERLAPPEDWINDOW | WS_VISIBLE, + 0, 0, 100, 100, NULL, NULL, NULL, NULL ); + ok( clip_hwnd != NULL, "CreateWindowA failed, GetLastError(): %x.\n", GetLastError() ); + ShowWindow( clip_hwnd, SW_SHOW ); + empty_message_queue(); + + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + + + clip_on_deactivate = 0; + clip_skip_cleanup = 0; + clip_default_cleanup = 0; + SetForegroundWindow( hwnd ); + empty_message_queue(); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &screen_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + + + clip_on_deactivate = 1; + clip_skip_cleanup = 0; + clip_default_cleanup = 0; + SetForegroundWindow( hwnd ); + empty_message_queue(); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + send_alt_tab(); + /* this is not working on w8*, w1064v1809_2scr and wine */ + if( GetForegroundWindow() == hwnd ) + { + ok( GetForegroundWindow() == hwnd, "Failed to change windows with simulated Alt-Tab\n" ); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &screen_rect ) || + EqualRect( &rect, &clip_rect ) /* wxppro, w2003std, w2008s64 */, + "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + } + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + clip_on_deactivate = 0; + clip_skip_cleanup = 1; + clip_default_cleanup = 0; + SetForegroundWindow( hwnd ); + empty_message_queue(); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + send_alt_tab(); + /* this is not working on w8*, w1064v1809_2scr and wine */ + if( GetForegroundWindow() == hwnd ) + { + ok( GetForegroundWindow() == hwnd, "Failed to change windows with simulated Alt-Tab\n" ); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &screen_rect ) || + EqualRect( &rect, &clip_rect ) /* wxppro, w2003std, w2008s64 */, + "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + } + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + clip_on_deactivate = 0; + clip_skip_cleanup = 0; + clip_default_cleanup = 1; + SetForegroundWindow( hwnd ); + empty_message_queue(); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + send_alt_tab(); + /* this is not working on w8*, w1064v1809_2scr and wine */ + if( GetForegroundWindow() == hwnd ) + { + ok( GetForegroundWindow() == hwnd, "Failed to change windows with simulated Alt-Tab\n" ); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &screen_rect ) || + EqualRect( &rect, &clip_rect ) /* wxppro, w2003std, w2008s64 */, + "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + } + SetForegroundWindow( clip_hwnd ); + empty_message_queue(); + + + clip_on_deactivate = 1; + clip_skip_cleanup = 0; + clip_default_cleanup = 0; + DestroyWindow( clip_hwnd ); + empty_message_queue(); + ok( GetForegroundWindow() == hwnd, "Unexpected foreground window: %p\n", GetForegroundWindow() ); + ret = GetClipCursor( &rect ); + ok( ret, "GetClipCursor failed.\n" ); + ok( EqualRect( &rect, &clip_rect ), "Unexpected ClipCursor rect %s.\n", wine_dbgstr_rect( &rect ) ); + + + ClipCursor( NULL ); + + DestroyWindow( clip_hwnd ); + DestroyWindow( hwnd ); + + UnregisterClassA( cls.lpszClassName, GetModuleHandleA( 0 ) ); +} + START_TEST(input) { POINT pos; @@ -2907,4 +3120,6 @@ START_TEST(input) test_GetPointerType(); else win_skip("GetPointerType is not available\n"); + + test_ClipCursor(); } -- 2.23.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57990 Your paranoid android. === w1064v1809_ar (32 bit report) === user32: input.c:1857: Test failed: 0: got L"\0634" expected L"a" input.c:1855: Test failed: 8: got 1 expected 0 input.c:1896: Test failed: ToAscii for character 'A' was 212 (expected 97) === w1064v1809_he (32 bit report) === user32: input.c:1857: Test failed: 0: got L"\05e9" expected L"a" input.c:1855: Test failed: 8: got 1 expected 0 input.c:1896: Test failed: ToAscii for character 'A' was 249 (expected 97) === w1064v1809_zh_CN (32 bit report) === user32: input.c:261: Test failed: 2/2: wrong message 105/000000e5/c0380001 expected WM_SYSKEYUP/00000012/c0380001 input.c:261: Test failed: 3/2: wrong message 105/00000058/a02d0001 expected WM_SYSKEYUP/00000058/e02d0001 input.c:261: Test failed: 3/3: wrong message 101/000000e5/80380001 expected WM_KEYUP/00000012/c0380001 input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:1155: Test failed: Unexpected vkCode 0xa2, expected 0. input.c:2749: Test failed: 0: wrong originId 4 input.c:2749: Test failed: 0: wrong originId 4
participants (2)
-
Marvin -
Rémi Bernon