Re: gdi32: Make the bitmap test pass under Windows 2000
Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
@@ -967,15 +970,19 @@ static void test_bitmap(void) hdc = CreateCompatibleDC(0); assert(hdc != 0);
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +}
It would be better to find values that work on all platforms, instead of disabling the test completely. -- Alexandre Julliard julliard(a)winehq.org
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
@@ -967,15 +970,19 @@ static void test_bitmap(void) hdc = CreateCompatibleDC(0); assert(hdc != 0);
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +}
It would be better to find values that work on all platforms, instead of disabling the test completely.
Yes, it would be better, but unfortunately I don't have windows 2000 installed around. -- Dmitry.
Dmitry Timoshkov wrote:
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
@@ -967,15 +970,19 @@ static void test_bitmap(void) hdc = CreateCompatibleDC(0); assert(hdc != 0);
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +} It would be better to find values that work on all platforms, instead of disabling the test completely.
Yes, it would be better, but unfortunately I don't have windows 2000 installed around.
If you need me to test something on a Win2K box (Vmware) just shout. -- Cheers, Paul.
"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote:
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +} It would be better to find values that work on all platforms, instead of disabling the test completely.
Yes, it would be better, but unfortunately I don't have windows 2000 installed around.
If you need me to test something on a Win2K box (Vmware) just shout.
We need to know what bitmap size is acceptable for CreateBitmap, so basically experimenting with first 2 parameters in the above test should answer that. -- Dmitry.
Dmitry Timoshkov wrote:
"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote:
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +} It would be better to find values that work on all platforms, instead of disabling the test completely.
Yes, it would be better, but unfortunately I don't have windows 2000 installed around.
If you need me to test something on a Win2K box (Vmware) just shout.
We need to know what bitmap size is acceptable for CreateBitmap, so basically experimenting with first 2 parameters in the above test should answer that.
OK, no problem but I can't do that right now. Will have to wait a few hours. Is there a specific combination you are looking for? Huge width, small height? Or the maximum size possible? -- Cheers, Paul.
"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote:
Is there a specific combination you are looking for? Huge width, small height?
Anything you could test that will lead to a reasonable conclusion.
Or the maximum size possible?
At least we need to know this one. -- Dmitry.
On Mon, Apr 21, 2008 at 10:40 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote:
Is there a specific combination you are looking for? Huge width, small height?
Anything you could test that will lead to a reasonable conclusion.
Or the maximum size possible?
At least we need to know this one.
The maximum values for both width and height on win2k is 32767. Anything above that on either parameter returns ERROR_INVALID_PARAMETER. Both params can be 32767 at the same time and the call will still succeed (assuming there's enough memory left). -- James Hawkins
James Hawkins wrote:
On Mon, Apr 21, 2008 at 10:40 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote:
Is there a specific combination you are looking for? Huge width, small height? Anything you could test that will lead to a reasonable conclusion.
Or the maximum size possible?
At least we need to know this one.
The maximum values for both width and height on win2k is 32767. Anything above that on either parameter returns ERROR_INVALID_PARAMETER. Both params can be 32767 at the same time and the call will still succeed (assuming there's enough memory left).
Yep, exactly what I just found. -- Cheers, Paul.
On Mon, Apr 21, 2008 at 10:06 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
"Alexandre Julliard" <julliard(a)winehq.org> wrote:
@@ -967,15 +970,19 @@ static void test_bitmap(void) hdc = CreateCompatibleDC(0); assert(hdc != 0);
+if (0) +{ /* this test fails under Win2k */ SetLastError(0xdeadbeef); hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); ok(hbmp != 0, "CreateBitmap should not fail\n"); DeleteObject(hbmp); +}
It would be better to find values that work on all platforms, instead of disabling the test completely.
Yes, it would be better, but unfortunately I don't have windows 2000 installed around.
-- Dmitry.
I've got about 6 2k boxes lying around at work I can test on...
participants (5)
-
Alexandre Julliard -
Austin English -
Dmitry Timoshkov -
James Hawkins -
Paul Vriens