re: winhttp: Correctly parse specified ports in WinHttpCrackUrl

[Dan Kegel]

Hi Paul,
you wrote
> Depends on my previous patch: winhttp/tests:...

The way we usually express that is to prefix each patch
with its position in the series of patches.  For instance,
your two-patch series might have used subject lines

[1/2] winhttp/tests: Add tests for WinHttpCrackUrl port number handling
[2/2] winhttp: Correctly parse specified ports in WinHttpCrackUrl

I like how you broke out the tests into a first patch.
(These days it's probably also ok to just include
both the tests and and the implementation
in a single patch if you prefer.)
- Dan

winhttp: Correctly parse specified ports in WinHttpCrackUrl

[Paul TBBle Hampson]

On Tue, Dec 30, 2008 at 11:51:13PM -0800, Dan Kegel wrote:
> Hi Paul,
> you wrote
> > Depends on my previous patch: winhttp/tests:...
> The way we usually express that is to prefix each patch
> with its position in the series of patches.  For instance,
> your two-patch series might have used subject lines
> [1/2] winhttp/tests: Add tests for WinHttpCrackUrl port number handling
> [2/2] winhttp: Correctly parse specified ports in WinHttpCrackUrl

Thanks for that, I'll keep that in mind for future.

-- 
-----------------------------------------------------------
Paul "TBBle" Hampson, B.Sc, LPI, MCSE
Very-later-year Asian Studies student, ANU
The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361)
Paul.Hampson(a)Pobox.com

Of course Pacman didn't influence us as kids. If it did,
we'd be running around in darkened rooms, popping pills and
listening to repetitive music.
 -- Kristian Wilson, Nintendo, Inc, 1989

License: http://creativecommons.org/licenses/by/2.5/au/
-----------------------------------------------------------