Re: richedit: Implement WB_DELIMITER and remove todo_wine's in tests.

[Paul Vriens]

On 07/26/2011 03:36 AM, James McKenzie wrote:
> if (wbuf[0] == 0x20 || wbuf[0] == 0xf020)
> -            todo_wine
> -                ok(result == delimiter_tests[i].isdelimiter,
> -                   "wanted ISDELIMITER_W(0x%x) %d, got %d\n",
> -                   delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result);
> +            ok(result == delimiter_tests[i].isdelimiter,
> +               "wanted ISDELIMITER_W(0x%x) %d, got %d\n",
> +               delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result);
>           else
>               ok(result == delimiter_tests[i].isdelimiter,
>                  "wanted ISDELIMITER_W(0x%x) %d, got %d\n",
> @@ -7122,10 +7121,9 @@ static void test_EM_FINDWORDBREAK_A(void)
>           SendMessageW(hwndRichEdit, WM_SETTEXT, 0, (LPARAM)buf);
>           result = SendMessage(hwndRichEdit, EM_FINDWORDBREAK, WB_ISDELIMITER, 0);
>           if (buf[0] == 0x20)
> -            todo_wine
> -                ok(result == delimiter_tests[i].isdelimiter,
> -                   "wanted ISDELIMITER_A(0x%x) %d, got %d\n",
> -                   delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result);
> +            ok(result == delimiter_tests[i].isdelimiter,
> +               "wanted ISDELIMITER_A(0x%x) %d, got %d\n",
> +               delimiter_tests[i].c, delimiter_tests[i].isdelimiter,result);
>           else

Hi James,

I think that the if/else was introduced to accommodate the todo_wine(). 
I guess you can remove more lines as the 'if' now contains the same code 
as the 'else'.

-- 
Cheers,

Paul.