[PATCH] d3d10core/tests: Remove useless casts to self

[Michael Stefaniuc]

Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org>
---
 dlls/d3d10core/tests/d3d10core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c
index 5b8e7e1c7b..9c322ed525 100644
--- a/dlls/d3d10core/tests/d3d10core.c
+++ b/dlls/d3d10core/tests/d3d10core.c
@@ -1648,7 +1648,7 @@ static void test_create_texture1d(void)
         desc.Format = DXGI_FORMAT_R32G32B32A32_TYPELESS;
         desc.BindFlags = D3D10_BIND_SHADER_RESOURCE;
         desc.MiscFlags = 0;
-        hr = ID3D10Device_CreateTexture1D(device, &desc, NULL, (ID3D10Texture1D **)&texture);
+        hr = ID3D10Device_CreateTexture1D(device, &desc, NULL, &texture);
         ok(hr == (i ? S_OK : E_INVALIDARG), "Test %u: Got unexpected hr %#x.\n", i, hr);
         if (SUCCEEDED(hr))
             ID3D10Texture1D_Release(texture);
@@ -1979,7 +1979,7 @@ static void test_create_texture2d(void)
         desc.Format = tests[i].format;
         desc.BindFlags = tests[i].bind_flags;
         desc.MiscFlags = tests[i].misc_flags;
-        hr = ID3D10Device_CreateTexture2D(device, &desc, NULL, (ID3D10Texture2D **)&texture);
+        hr = ID3D10Device_CreateTexture2D(device, &desc, NULL, &texture);
 
         todo_wine_if(tests[i].todo)
         ok(hr == (tests[i].succeeds ? S_OK : E_INVALIDARG),
@@ -2223,7 +2223,7 @@ static void test_create_texture3d(void)
     {
         desc.Format = tests[i].format;
         desc.BindFlags = tests[i].bind_flags;
-        hr = ID3D10Device_CreateTexture3D(device, &desc, NULL, (ID3D10Texture3D **)&texture);
+        hr = ID3D10Device_CreateTexture3D(device, &desc, NULL, &texture);
 
         todo_wine_if(tests[i].todo)
         ok(hr == (tests[i].succeeds ? S_OK : E_INVALIDARG), "Test %u: Got unexpected hr %#x.\n", i, hr);
@@ -7634,8 +7634,8 @@ static void test_cube_maps(void)
         {
             for (j = 0; j < ARRAY_SIZE(data); ++j)
                 data[j] = sub_resource_idx;
-            ID3D10Device_UpdateSubresource(device, (ID3D10Resource *)texture, sub_resource_idx, NULL,
-                    data, texture_desc.Width * sizeof(*data), 0);
+            ID3D10Device_UpdateSubresource(device, texture, sub_resource_idx, NULL, data,
+                    texture_desc.Width * sizeof(*data), 0);
         }
 
         expected_result.y = expected_result.z = 0.0f;
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=47477

Your paranoid android.


=== debian9 (32 bit report) ===

d3d10core:
d3d10core.c:4626: Test failed: Got unexpected hr 0x8876086a.
Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ed24978).

=== debian9 (32 bit Japanese:Japan report) ===

d3d10core:
d3d10core.c:4626: Test failed: Got unexpected hr 0x8876086a.
Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ec3c978).

=== debian9 (32 bit Chinese:China report) ===

d3d10core:
d3d10core.c:4423: Test failed: Got unexpected hr 0x8876086a for query type 4.
Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7eb6e978).

=== debian9 (32 bit WoW report) ===

d3d10core:
Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ed2e978).

[Michael Stefaniuc]

On 2/11/19 10:46 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Nice try...
> This is a true no-op patch and the crashes are pre-existent.

bye
	michael
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=47477
>
> Your paranoid android.
>
> === debian9 (32 bit report) ===
>
> d3d10core:
> d3d10core.c:4626: Test failed: Got unexpected hr 0x8876086a.
> Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ed24978).
>
> === debian9 (32 bit Japanese:Japan report) ===
>
> d3d10core:
> d3d10core.c:4626: Test failed: Got unexpected hr 0x8876086a.
> Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ec3c978).
>
> === debian9 (32 bit Chinese:China report) ===
>
> d3d10core:
> d3d10core.c:4423: Test failed: Got unexpected hr 0x8876086a for query type 4.
> Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7eb6e978).
>
> === debian9 (32 bit WoW report) ===
>
> d3d10core:
> Unhandled exception: page fault on read access to 0x6976656c in 32-bit code (0x7ed2e978).

[Henri Verbeet]

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>