Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

[Jacek Caban]

Hi Hans,

On 07/23/11 09:52, Hans Leidekker wrote:
> @@ -2107,7 +2107,7 @@ static void test_IWinHttpRequest(void)
>      HRESULT hr;
>      IWinHttpRequest *req;
>      BSTR method, url, response = NULL, status_text = NULL;
> -    VARIANT async, empty, timeout;
> +    VARIANT async, empty, timeout, body;
>      VARIANT_BOOL succeeded;
>      LONG status;
>
> @@ -2241,6 +2241,13 @@ static void test_IWinHttpRequest(void)
>      ok( hr == S_OK, "got %08x\n", hr );
>      SysFreeString( response );
>
> +    VariantInit( &body );
> +    V_VT( &body ) = VT_ERROR;
> +    hr = IWinHttpRequest_get_ResponseBody( req, &body );
> +    ok( hr == S_OK, "got %08x\n", hr );
> +    ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &body ) );
> +
> +    ok( hr == S_OK, "got %08x\n", hr );

This duplicates the above test. Did you mean to test the result of
VariantClear here (otherwise there is a leak)?

Thanks,
    Jacek

[2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)

[Hans Leidekker]

On Sat, 2011-07-23 at 16:01 +0200, Jacek Caban wrote:
> > +    VariantInit( &body );
> > +    V_VT( &body ) = VT_ERROR;
> > +    hr = IWinHttpRequest_get_ResponseBody( req, &body );
> > +    ok( hr == S_OK, "got %08x\n", hr );
> > +    ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &body ) );
> > +
> > +    ok( hr == S_OK, "got %08x\n", hr );
>
> This duplicates the above test. Did you mean to test the result of
> VariantClear here (otherwise there is a leak)?

Yes, looks like that line got lost somehow. Thanks for the notice.