Re: [PATCH] also remove backbuffer flags in the v1 DDRAW interface

[Austin English]

On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote:
> Hi,
>
> This fixes http://bugs.winehq.org/show_bug.cgi?id=9008
> by also filtering out the backbuffer flag.
>
> Ciao, Marcus
> ---
>  dlls/ddraw/ddraw_thunks.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c
> index b748ad4..c77b3bb 100644
> --- a/dlls/ddraw/ddraw_thunks.c
> +++ b/dlls/ddraw/ddraw_thunks.c
> @@ -386,10 +386,10 @@ IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc,
>     IDirectDrawSurfaceImpl *impl;
>     HRESULT hr;
>
> -    /* Remove front buffer flag, this causes failure in v7, and its added to normal
> -     * primaries anyway
> +    /* Remove front and back buffer flag, this causes failure in v7,
> +     * and its added to normal primaries anyway.

Nitpick, but typo there: should be "it's", not "its"

-Austin

[PATCH] also remove backbuffer flags in the v1 DDRAW interface

[Marcus Meissner]

On Sun, Oct 05, 2008 at 05:41:31PM -0500, Austin English wrote:
> On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote:
> > Hi,
> >
> > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008
> > by also filtering out the backbuffer flag.
> >
> > Ciao, Marcus
> > ---
> >  dlls/ddraw/ddraw_thunks.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c
> > index b748ad4..c77b3bb 100644
> > --- a/dlls/ddraw/ddraw_thunks.c
> > +++ b/dlls/ddraw/ddraw_thunks.c
> > @@ -386,10 +386,10 @@ IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc,
> >     IDirectDrawSurfaceImpl *impl;
> >     HRESULT hr;
> >
> > -    /* Remove front buffer flag, this causes failure in v7, and its added to normal
> > -     * primaries anyway
> > +    /* Remove front and back buffer flag, this causes failure in v7,
> > +     * and its added to normal primaries anyway.
>
> Nitpick, but typo there: should be "it's", not "its"

It also fails in patchwatcher (and locally, not caused by my
installation), please disregard the patch. :/

Ciao, Marcus