Re: abnt2 keyboard patch

[Dmitry Timoshkov]

"Rafael аvila de EspМndola" <rafael.espindola(a)ic.unicamp.br> wrote:
> I have tested the patch with a abnt2 and a us-int keyboard. Both work
> correctly.
>
> Dmitry: Do you think that the "magic numbers" are reasonably explained? What I
> have done is basically to treat the comma similarilly to the decimal period.
> The numbers are different from the first patch because in the first one I
> haven't fixed the main_key_scan_abnt_qwerty and main_key_vkey_abnt_qwerty
> tables.

I still see problems with your patch.

1. You are using 'keysym == 0x2C' for comma, but what happens if NumLock
is on, and you press comma on the main keyboard, not on the keypad?
Shouldn't X11 send XK_KP_xxx event in that case (something like XK_KP_Decimal)?

2. Please generate unified diffs, 'using diff -u' for patches.

--
Dmitry.