[PATCH] msvcrt: Cleanup sprintf tests.
Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msvcrt/tests/printf.c | 806 +++++++++---------------------------- 1 file changed, 193 insertions(+), 613 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=58808 Your paranoid android. === w1064v1809 (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809_2scr (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809_ar (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809_he (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809_ja (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809_zh_CN (32 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = "" === w1064v1809 (64 bit report) === msvcrt: printf.c:264: Test failed: 46) r = 1, expected 2 printf.c:265: Test failed: 46) buffer = "1" printf.c:265: Test failed: 78) buffer = "%kmqrtvyz" printf.c:264: Test failed: 99) r = 0, expected 1 printf.c:265: Test failed: 99) buffer = ""
All of these failures are not new, only failure message/line was changed. Thanks, Piotr
On Thu, 31 Oct 2019, Piotr Caban wrote:
All of these failures are not new, only failure message/line was changed.
The TestBot ignores changes in the line number. The reason why it could not match these errors with the existing ones is the additional '%d)' at the beginning of the failure message which indicates the loop counter. But of course it totally makes sense to add this information. -- Francois Gouget <fgouget(a)codeweavers.com>
participants (4)
-
Francois Gouget -
Marvin -
Piotr Caban -
Piotr Caban