Re: [RESEND] Sync (47): shlwapi tests

[Alexandre Julliard]

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes:
> Any problems with this one?

You said yourself that the some of the tests are currently failing;
I cannot commit tests that fail, that would make the regression test
suite useless.

-- 
Alexandre Julliard
julliard(a)winehq.com

[RESEND] Sync (47): shlwapi tests

[Uwe Bonnes]

> > > > > "Alexandre" == Alexandre Julliard <julliard(a)winehq.org> writes:

Alexandre> Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes:
    >> Any problems with this one?

    Alexandre> You said yourself that the some of the tests are currently
    Alexandre> failing; I cannot commit tests that fail, that would make the
    Alexandre> regression test suite useless.

But we have a keyword for tests that we expect to fail. So changing the
expected result to failing should make the patch appyable.

Bye
-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------