Re: mscoree: Stub for LoadStringRCEx and LoadStringRC

[Dmitry Timoshkov]

"Paul Chitescu" <paulc(a)voip.null.ro> wrote:
> +HRESULT WINAPI LoadStringRCEx(LCID culture, UINT resId, LPWSTR pBuffer, int iBufLen, int bQuiet, int* pBufLen)
> +{
> +    HRESULT res = S_OK;
> +    if ((iBufLen <= 0) || !pBuffer)
> +        return E_INVALIDARG;
> +    pBuffer[0] = 0;
> +    if (resId) {
> +        WARN("(%d, %x, %p, %d, %d, %p): semi-stub\n", culture, resId, pBuffer, iBufLen, bQuiet, pBufLen);

This should be a FIXME not a WARN.
> +        res = ERROR_CALL_NOT_IMPLEMENTED;
> +    }
> +    else
> +        res = E_FAIL;

You are mixing OLE error codes with ERROR_xxx ones, this doesn't look right.

-- 
Dmitry.