Re: [v2 2/2] d3d11/tests: Add test of SV_VertexID.

[Józef Kucia]

On Fri, Nov 18, 2016 at 6:06 AM, Andrew Wesie <awesie(a)gmail.com> wrote:
> +static void test_sm4_vertexid(void)

I would drop the "sm4" prefix.
> +    static const D3D11_INPUT_ELEMENT_DESC layout_desc[] =
> +    {
> +        { "SV_Position", 0, DXGI_FORMAT_R32G32_FLOAT, 0, 0, D3D11_INPUT_PER_VERTEX_DATA, 0 },
> +        { "SV_VertexID", 0, DXGI_FORMAT_R32_UINT, 1, 0, D3D11_INPUT_PER_VERTEX_DATA, 0 },
> +    };

I don't think that SV_VertexID should be a part of the input layout.

[v2 2/2] d3d11/tests: Add test of SV_VertexID.

[Henri Verbeet]

On 21 November 2016 at 01:43, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
> > +    static const D3D11_INPUT_ELEMENT_DESC layout_desc[] =
> > +    {
> > +        { "SV_Position", 0, DXGI_FORMAT_R32G32_FLOAT, 0, 0, D3D11_INPUT_PER_VERTEX_DATA, 0 },
> > +        { "SV_VertexID", 0, DXGI_FORMAT_R32_UINT, 1, 0, D3D11_INPUT_PER_VERTEX_DATA, 0 },
> > +    };
>
> I don't think that SV_VertexID should be a part of the input layout.

I'll note that that's an unusual way to use SV_Position as well.