Re: iphlpapi.dll (take 2)

[Alexandre Julliard]

Juan Lang <juan_lang(a)yahoo.com> writes:
> Removed C++-style comments.
> Supercedes
> http://www.winehq.org/hypermail/wine-patches/2003/05/0069.html
>
> ChangeLog: Adds an implementation of iphlpapi.dll;
> most Get*
> functions introduced through Win98 are included.

The implementation should use the same function names as the exported
entry points, without the IPHLPAPI_ prefix, exactly the way they are
declared in iphlpapi.h. For instance

DWORD __stdcall IPHLPAPI_AddIPAddress(...)

should really be

DWORD WINAPI AddIPAddress(...)

etc.

Also you can't share code by putting source files in misc/. All source
files must be local to the dll, and other dlls have to use the
exported API exclusively. And please use diff -u to make patches.

-- 
Alexandre Julliard
julliard(a)winehq.com

iphlpapi.dll (take 2)

[Juan Lang]

_really_ appreciate the quick, positive feedback from
everyone here.  Resubmitted.

--Juan

--- Alexandre Julliard <julliard(a)winehq.com> wrote:
> The implementation should use the same function
> names as the exported
> entry points, without the IPHLPAPI_ prefix, exactly
> the way they are
> declared in iphlpapi.h. For instance
>
> DWORD __stdcall IPHLPAPI_AddIPAddress(...)
>
> should really be
>
> DWORD WINAPI AddIPAddress(...)
>
> etc.
>
> Also you can't share code by putting source files in
> misc/. All source
> files must be local to the dll, and other dlls have
> to use the
> exported API exclusively. And please use diff -u to
> make patches.
>
> -- 
> Alexandre Julliard
> julliard(a)winehq.com

__________________________________
Do you Yahoo!?
The New Yahoo! Search - Faster. Easier. Bingo.
http://search.yahoo.com