Re: [1/3] d3dxof: Make parsing more permissive about semicolon and comma in objects

[Paul Vriens]

Christian Costa wrote:
> ------------------------------------------------------------------------

Hi Christian,

+      if ((token != TOKEN_SEMICOLON) && (token != TOKEN_COMMA))
        {
          /* Allow comma instead of semicolon in some specific cases */
          if (!((token == TOKEN_COMMA) && ((i+1) < pt->nb_members) && 
(pt->members[i].type == pt->members[i+1].type)

This introduced a DEADCODE warning in Coverity. The code changed was in 
d3dxof.c but was moved in a later patch to parsing.c.

Could you have a look?

-- 
Cheers,

Paul.

[1/3] d3dxof: Make parsing more permissive about semicolon and comma in objects

[Christian Costa]

Hi Paul,

I'm just sending a patch to fix that. Thanks for spotting.

Bye,
Christian

Paul Vriens a écrit :
> Christian Costa wrote:
> > ------------------------------------------------------------------------
>
> Hi Christian,
>
> +      if ((token != TOKEN_SEMICOLON) && (token != TOKEN_COMMA))
>        {
>          /* Allow comma instead of semicolon in some specific cases */
>          if (!((token == TOKEN_COMMA) && ((i+1) < pt->nb_members) && 
> (pt->members[i].type == pt->members[i+1].type)
>
> This introduced a DEADCODE warning in Coverity. The code changed was 
> in d3dxof.c but was moved in a later patch to parsing.c.
>
> Could you have a look?