Re: Cpp Check Nov. 7th

[chris ahrendt]

Alexandre Julliard wrote:
> chris ahrendt <celticht32(a)yahoo.com> writes:
> > Well its  been a few since I ran CPP Check and so I ran it today and got the following:
> >
> > New CPP Check Errors for the Wine Code:
> >
> > [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized variable: bmi_buf
> > [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd
> > [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd
> > [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szText
> > [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szTitle
> > [/home/cahrendt/wine-git/dlls/shell32/shellpath.c:1360]: (error) Uninitialized variable: InfoBuffer
> > [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd
> > [/home/cahrendt/wine-git/server/mapping.c:118]: (error) Uninitialized variable: page_size
>
> These are once again all false positives. I don't think there's any
> point in continuing to post such reports, at least not until cppcheck
> becomes more reliable.

Will report them to CPPcheck

are you sure though all of these are false positives?

chris

Cpp Check Nov. 7th

[Alexandre Julliard]

chris ahrendt <celticht32(a)yahoo.com> writes:
> Alexandre Julliard wrote:
> > chris ahrendt <celticht32(a)yahoo.com> writes:
> > > Well its  been a few since I ran CPP Check and so I ran it today and got the following:
> > >
> > > New CPP Check Errors for the Wine Code:
> > >
> > > [/home/cahrendt/wine-git/dlls/comctl32/imagelist.c:1908]: (error) Uninitialized variable: bmi_buf
> > > [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd
> > > [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd
> > > [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szText
> > > [/home/cahrendt/wine-git/dlls/shell32/shellord.c:416]: (error) Uninitialized variable: szTitle
> > > [/home/cahrendt/wine-git/dlls/shell32/shellpath.c:1360]: (error) Uninitialized variable: InfoBuffer
> > > [/home/cahrendt/wine-git/dlls/winex11.drv/xfont.c:2963]: (possible error) Resource leak: fd
> > > [/home/cahrendt/wine-git/server/mapping.c:118]: (error) Uninitialized variable: page_size
> >
> > These are once again all false positives. I don't think there's any
> > point in continuing to post such reports, at least not until cppcheck
> > becomes more reliable.
>
> Will report them to CPPcheck
>
> are you sure though all of these are false positives?

Yes, there isn't a single legitimate bug in there.

-- 
Alexandre Julliard
julliard(a)winehq.org