Re: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile

[Paul Vriens]

On 03/17/2010 04:21 PM, Ilya Basin wrote:
> @@ -1013,7 +1011,7 @@ static void test_filename(void)
>                  "%s failed: rc=%d err=%d\n", shell_call,
>                  rc, GetLastError());
>           }
> -        else todo_wine
> +        else
>           {
>               ok(rc==test->rc, "%s failed: rc=%d err=%d\n", shell_call,
>                  rc, GetLastError());

Hi Ilya,

If this is no longer a todo_wine you should change the filename_tests 
struct:

     /* Test file masked due to space */
     {NULL,           "%s\\masked file.shlexec",   0x1, 33},

to

     /* Test file masked due to space */
     {NULL,           "%s\\masked file.shlexec",   0x0, 33},


You can even consider removing the "if ((test->todo & 0x1)==0)" as now 
there are no more of those tests.

On the one hand it's nice to have these todo constructs, removing them 
however is a greater incentive to get the implementation right ;)

-- 
Cheers,

Paul.

Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile

[Ilya Basin]

PV> If this is no longer a todo_wine you should change the filename_tests
PV> struct:
You're right.

Do you have any clue why this block of code was added to
SHELL_execute() ?

Re[2]: shell32: remove unneeded parsing of SHELLEXECUTEINFO.lpFile

[Ricardo Filipe]

2010/3/18 Ilya Basin <basinilya(a)gmail.com>:
> PV> If this is no longer a todo_wine you should change the filename_tests
> PV> struct:
> You're right.
>
> Do you have any clue why this block of code was added to
> SHELL_execute() ?

try git blame and see if the commit message is of any help...