[PATCH] shlwapi/tests: Test a NULL flags pointer for SHFormatDateTime().

[Francois Gouget]

It's equivalent to FDTF_DEFAULT.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---
 dlls/shlwapi/tests/ordinal.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/dlls/shlwapi/tests/ordinal.c b/dlls/shlwapi/tests/ordinal.c
index 8a294ec1751..187167dcb2a 100644
--- a/dlls/shlwapi/tests/ordinal.c
+++ b/dlls/shlwapi/tests/ordinal.c
@@ -1715,6 +1715,21 @@ static void test_SHFormatDateTimeA(void)
     ok(GetLastError() == 0xdeadbeef,
         "expected 0xdeadbeef, got %d\n", GetLastError());
 
+    flags = FDTF_DEFAULT;
+    ret = pSHFormatDateTimeA(&filetime, &flags, buff, sizeof(buff));
+    ok(ret == lstrlenA(buff)+1, "got %d\n", ret);
+
+    buff2[0] = '\0';
+    flags = FDTF_SHORTDATE | FDTF_SHORTTIME;
+    ret = pSHFormatDateTimeA(&filetime, &flags, buff2, sizeof(buff2));
+    ok(ret == lstrlenA(buff2)+1, "got %d\n", ret);
+    ok(lstrcmpA(buff, buff2) == 0, "expected (%s), got (%s)\n", buff, buff2);
+
+    buff2[0] = '\0';
+    ret = pSHFormatDateTimeA(&filetime, NULL, buff2, sizeof(buff2));
+    ok(ret == lstrlenA(buff2)+1, "got %d\n", ret);
+    ok(lstrcmpA(buff, buff2) == 0, "expected (%s), got (%s)\n", buff, buff2);
+
     /* now check returned strings */
     flags = FDTF_NOAUTOREADINGORDER | FDTF_SHORTTIME;
     ret = pSHFormatDateTimeA(&filetime, &flags, buff, sizeof(buff));
-- 
2.30.2

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=97013

Your paranoid android.


=== debiant2 (32 bit Hindi:India report) ===

shlwapi:
ordinal.c:1742: Test failed: expected (01-09-2021 05:10), got (05:10)
ordinal.c:1749: Test failed: expected (01-09-2021 05:10), got (05:10:51)
ordinal.c:1757: Test failed: expected (01-09-2021 05:10), got (05:10:51)
ordinal.c:1764: Test failed: expected (01-09-2021 05:10), got (01-09-2021)
ordinal.c:1771: Test failed: expected (01-09-2021 05:10), got (01 ??????? 2021)
ordinal.c:1779: Test failed: expected (01-09-2021 05:10), got (01 ??????? 2021)
ordinal.c:1787: Test failed: expected (F), got (0) for time part
ordinal.c:1793: Test failed: expected (01-09-2021 05:10) got (01 ??????? 2021,) for date part
ordinal.c:1801: Test failed: expected (F), got (1) for time part
ordinal.c:1807: Test failed: expected (01-09-2021 05:10) got (01 ??????? 2021,) for date part
ordinal.c:1819: Test failed: expected (01-09-2021 05:10 F), got (01-09-2021 05:10)
ordinal.c:1830: Test failed: expected (01-09-2021 05:10 F F), got (01-09-2021 05:10:51)