Re: SetDesktopWallPaper() should call SystemParametersInfoA()

[Dmitry Timoshkov]

"Andrew Ziem" <ahziem1(a)mailbolt.com> wrote:
> -static HBITMAP hbitmapWallPaper;
> -static SIZE bitmapSize;
> -static BOOL fTileWallPaper;
> +HBITMAP hbitmapWallPaper; /* desktop wallpaper */
> +SIZE bitmapSize; /* size of desktop wallpaper */
> +BOOL fTileWallPaper;

If the varaibles are no more used in this file you should not make
static variables public, but move them into appropriate file instead.

-- 
Dmitry.

SetDesktopWallPaper() should call SystemParametersInfoA()

[Andrew Ziem]

Dmitry Timoshkov wrote:
> "Andrew Ziem" <ahziem1(a)mailbolt.com> wrote:
> > -static HBITMAP hbitmapWallPaper;
> > -static SIZE bitmapSize;
> > -static BOOL fTileWallPaper;
> > +HBITMAP hbitmapWallPaper; /* desktop wallpaper */
> > +SIZE bitmapSize; /* size of desktop wallpaper */
> > +BOOL fTileWallPaper;
>
> If the varaibles are no more used in this file you should not make
> static variables public, but move them into appropriate file instead.

All these variables are now used in two files: desktop.c and sysparams.c


Andrew

SetDesktopWallPaper() should call SystemParametersInfoA()

[Dmitry Timoshkov]

"Andrew Ziem" <ahziem1(a)mailbolt.com> wrote:
> > If the varaibles are no more used in this file you should not make
> > static variables public, but move them into appropriate file instead.
>
> All these variables are now used in two files: desktop.c and sysparams.c

Ah, sorry, didn't notice that they are still in use. Anyway, it's better
to not spread internals around, probably it's time to merge functionality
in one place.

-- 
Dmitry.