Re: [PATCH] x11drv: Allow to disable focus to desktop window after last wine window looses focus.

[Vitaliy Margolen]

Tomas Carnecky wrote:
> This patch introduces a new registry key, "FocusDesktopWindow", that can 
> be used to specify whether wine should set the foreground window to the 
> desktop window after the last wine app looses focus. The default is 
> enabled (the same behavior as now).

This is a bad hack. The reason I *fixed* the focus lose so Wine can grab pointer
inside it's window and release it when the focus is lost. With what you proposing,
it will be impossible. Then I'd like to see what would you say when Wine will not
be releasing the mouse when you switch away from app?

Also I don't know how many apps did you really test, but lots and lots of apps
can't get the focus because they think they never lost it. Which IMHO is the
reason for most bugs where input goes into terminal not Wine.
> For example World of Warcraft stops sound if it finds out it lost focus and
> there's currently a bug in wine that makes WoW unaware that it regained focus,
> which effectively disables sound.
> Then you should fix this bug and not create hacks.

Vitaliy

[PATCH] x11drv: Allow to disable focus to desktop window after last wine window looses focus.

[Tomas Carnecky]

Vitaliy Margolen wrote:
> Tomas Carnecky wrote:
> > This patch introduces a new registry key, "FocusDesktopWindow", that 
> > can be used to specify whether wine should set the foreground window 
> > to the desktop window after the last wine app looses focus. The 
> > default is enabled (the same behavior as now).
>
> This is a bad hack. The reason I *fixed* the focus lose so Wine can grab

Ok, so there's no easy way to make the app believe it has focus when it 
doesn't? Linux usually has virtual desktops, I think it wouldn't be bad 
if we could make an app believe it owns the focus while the user 
switches to a different virtual desktop and does something else there.
> > For example World of Warcraft stops sound if it finds out it lost 
> > focus and
> > there's currently a bug in wine that makes WoW unaware that it 
> > regained focus,
> > which effectively disables sound.
> > Then you should fix this bug and not create hacks.

I have zero knowledge about gdi32/user32, I can't fix that bug myself, 
not without spending weeks digging through the code. If you have an idea 
what could cause the bug, I'll test patches etc and if you think it's 
something that'll take longer to fix, I'll open a bug. But there's not 
much more I can do at this moment.
I already thought about asking Blizzard how they check whether WoW has 
focus or not, but there's no point since they'd ignore my emails again.

tom