Re: wined3d/context: Remove a trivial call to context_validate_onscreen_formats() in context_apply_blit_state().

[Henri Verbeet]

On 10 March 2011 20:22, Adam Martinson <amartinson(a)codeweavers.com> wrote:
> -        context_validate_onscreen_formats(device, context, NULL);
> +        /* It's silly to call context_validate_onscreen_formats() with a NULL depth_stencil. */
> Sigh. I've asked you a very simple question about the performance
> impact of these changes *twice* now, and you ignored the question both
> times.

Unless you have evidence that the compiler fails to eliminate the call
by itself, and this actually makes any kind of difference, consistency
is more important. The same goes for the
IWineD3DDeviceImpl_MarkStateDirty() change, though at least in that
case there's somewhat of a remote chance of it making a difference.

wined3d/context: Remove a trivial call to context_validate_onscreen_formats() in context_apply_blit_state().

[Adam Martinson]

On 03/11/2011 06:50 AM, Henri Verbeet wrote:
> Sigh. I've asked you a very simple question about the performance
> impact of these changes *twice* now, and you ignored the question both
> times.
>
> Unless you have evidence that the compiler fails to eliminate the call
> by itself, and this actually makes any kind of difference, consistency
> is more important.
> Obviously for a change this small the difference is not measurable.  I 
> don't think trivial function calls are ever correct, here or anywhere 
> else.  I don't know whether that call compiles out, but I know for sure 
> that a comment does.