Czech language resources encoding fix

[Petr Tesarik]

Hi everyone,

On 8 Feb I sent a patch to fix the encoding of Czech resources in
Wine (see wine-patches), but nothing seems to have happened.  Is
something wrong with the patch?

Of course, I double-checked the "Sending patches" page:

# Include a ChangeLog entry with your name, email address and a
  description of what your patch does.

There is a ChangeLog entry and a (IMO concise) description of what the
patch does.

# Keep the patch small and the point of the change clear.
# Submit one fix or group of related changes per patch.

Well, OK, I could possibly break the patch into numerous smaller ones,
each fixing only one of the resource files. Is that what you expect?

# Generate your patch against the latest version of Wine from the
  WineHQ CVS (see below).

It applies cleanly against latest CVS.

# Test your patch, and if possible write a test case demonstrating it
  is correct.

Umgh. Does changing a resource string need writing a test case?

# Be careful to not corrupt the patch through line-wrapping.

Not the case.

# Avoid unnecessarily changing the formatting of the code.

No.

# Use standard C, avoid C++ comments and inline variable declarations.

They'r resource files. No C/C++ comments at all.

# Read the diff and make sure it contains only what you want in it.

Done.


Thanks for any clue,
Petr Tesarik

[Mike McCormack]

Petr Tesarik wrote:
> # Keep the patch small and the point of the change clear.
> # Submit one fix or group of related changes per patch.
>
> Well, OK, I could possibly break the patch into numerous smaller ones,
> each fixing only one of the resource files. Is that what you expect?

Yes.  Alexandre is low bandwidth ;)

Mike

[Petr Tesarik]

Dne 02/13/06 v 18:49:46 (+0900), Mike McCormack napsal(a):
> =20
> Petr Tesarik wrote:
> =20
> > # Keep the patch small and the point of the change clear.
> > # Submit one fix or group of related changes per patch.
> >
> > Well, OK, I could possibly break the patch into numerous smaller ones,
> > each fixing only one of the resource files. Is that what you expect?
> > =20
> > Yes.  Alexandre is low bandwidth ;)
> > =20
> > Mike

This makes for 29 separate patches which supercede the original one.
Not really happy, though. Splitting the patch and resubmitting it all,
while double-checking that the encoding didn't get f**d up in the
process was not at all an easy task. I hope it really is what you
meant...

Thanks for the tip, anyway.

Petr