Re: [5/17]dwrite: Shift to using localized string for family name

[Nikolay Sivov]

> +HRESULT clone_localizedstring(IDWriteLocalizedStrings *iface, IDWriteLocalizedStrings **strings)

This looks unnecessary, as you can do create_localizedstrings() and a 
series of add_localizedstring() after.

[5/17]dwrite: Shift to using localized string for family name

[Aric Stewart]

Later, when I start reading the family name from the font 'name' table, 
is where this is more relevant.

I will try rebasing and moving this patch to that area of the code so 
that it makes more sense.

-aric


On Tue Sep  2 16:51:40 2014, Nikolay Sivov wrote:
> > +HRESULT clone_localizedstring(IDWriteLocalizedStrings *iface, IDWriteLocalizedStrings **strings)
>
> This looks unnecessary, as you can do create_localizedstrings() and a series of add_localizedstring() after.

[5/17]dwrite: Shift to using localized string for family name

[Nikolay Sivov]

On 09/03/2014 04:15 PM, Aric Stewart wrote:
> Later, when I start reading the family name from the font 'name' table,
> is where this is more relevant.
>
> I will try rebasing and moving this patch to that area of the code so
> that it makes more sense.

Ok. I don't see why we can't reuse create_localizedstrings() in any 
case. That's normal to have initialization/allocation part in one place.
If it needs to be modified, sure, let's make it do what you need.
> -aric
>
> On Tue Sep  2 16:51:40 2014, Nikolay Sivov wrote:
> > > +HRESULT clone_localizedstring(IDWriteLocalizedStrings *iface,
> > > IDWriteLocalizedStrings **strings)
> >
> > This looks unnecessary, as you can do create_localizedstrings() and a
> > series of add_localizedstring() after.