Re: dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8488

Your paranoid android.


=== WNT4WSSP6 (32 bit device) ===
device.c:168: Test failed: DirectInputCreate() failed: 80040154

dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Vitaliy Margolen]

On 01/20/2011 07:52 PM, Marvin wrote:
> === WNT4WSSP6 (32 bit device) ===
> device.c:168: Test failed: DirectInputCreate() failed: 80040154

Does this box has any newer version of DX installed at all? If it doesn't 
know about DX2 interfaces I'm guessing not.

Vitaliy

dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Greg Geldorp]

From: Vitaliy Margolen
> On 01/20/2011 07:52 PM, Marvin wrote:
> > === WNT4WSSP6 (32 bit device) ===
> > device.c:168: Test failed: DirectInputCreate() failed: 80040154
>
> Does this box has any newer version of DX installed at all? If it doesn't 
> know about DX2 interfaces I'm guessing not.

I've tried to install the June 2010 DirectX redistributable on it, but it
won't even start the setup program. Says the setup program is not a valid
Windows NT application, which happens if the
Major/MinorOperatingSystemVersion
in the PE header is set to 5.0.
So in short, no, there's no recent DX version installed.

Greg

dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Vitaliy Margolen]

On 01/21/2011 01:43 AM, Greg Geldorp wrote:
> I've tried to install the June 2010 DirectX redistributable on it
> Shame on me, I've totally forgot that the latest DX version for NT was DX3 
> that came with service pack. Don't recall thou if it was a separate install 
> or not.

The patch still should go in as-is. Will send a fix for NT later.

Vitaliy.

dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Greg Geldorp]

From: Vitaliy Margolen [mailto:wine-patches(a)kievinfo.com]
> Shame on me, I've totally forgot that the latest DX version for NT was DX3
> that came with service pack. Don't recall thou if it was a separate install
> or not.

Wikipedia says (http://en.wikipedia.org/wiki/DirectX#Releases) that DirectX 3.0a
was the last supported version of DX for NT4 and it was included in SP3. The VM
runs SP6, I've checked the version info of dinput.dll, it says "4.04" without
further qualifications. winetest.exe dumps the version number 4.4.1381.4
(http://test.winehq.org/data/55f6f9ada43acef87b4ee10096997ac73e4e8e23/nt4_wtb...)

Greg.

dinput: Combine ASCII and Unicode device create callbacks. Add tests. (try 2)

[Vitaliy Margolen]

On 01/21/2011 08:43 AM, Greg Geldorp wrote:
> From: Vitaliy Margolen [mailto:wine-patches(a)kievinfo.com]
> > Shame on me, I've totally forgot that the latest DX version for NT was DX3
> > that came with service pack. Don't recall thou if it was a separate install
> > or not.
>
> Wikipedia says (http://en.wikipedia.org/wiki/DirectX#Releases) that DirectX 3.0a
> was the last supported version of DX for NT4 and it was included in SP3.
> It's been a while since I last touched NT 4.0. It was my O/S of choice for 
> many years... Forgot lots of details about it by now.

I've modified the test to skip on NT 4.0 same as the current version skips.

Vitaliy.