Re: Alexandre Julliard : server: Don' t clip update regions to the desktop window.

[Ken Thomases]

On Jul 5, 2018, at 3:25 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Module: wine
> Branch: master
> Commit: 8cfac3b218669edcef8b92ea8370b0579eb23ea9
> URL:    https://source.winehq.org/git/wine.git/?a=commit;h=8cfac3b218669edcef8b92ea8...
>
> Author: Alexandre Julliard <julliard(a)winehq.org>
> Date:   Thu Jul  5 12:48:13 2018 +0200
>
> server: Don't clip update regions to the desktop window.
>
> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>
>
> ---
>
> dlls/user32/tests/msg.c |  4 ++--
> server/window.c         | 23 ++++++++---------------
> 2 files changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
> index 0cfafe4..cb918fa 100644
> --- a/dlls/user32/tests/msg.c
> +++ b/dlls/user32/tests/msg.c
> @@ -4760,7 +4760,7 @@ static void test_showwindow(void)
>     flush_sequence();
>     ShowWindow(hwnd, SW_SHOWMAXIMIZED);
>     ok_sequence(WmShowMaxPopupResizedSeq_todo,
> -            "ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO", TRUE);
> +            "ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO", FALSE);

Should the name of the test sequence and the context string both have "_todo"/" TODO" removed? (Although "WmShowMaxPopupResizedSeq" is already used for a difference sequence.)

-Ken

Alexandre Julliard : server: Don' t clip update regions to the desktop window.

[Alexandre Julliard]

Ken Thomases <ken(a)codeweavers.com> writes:
> On Jul 5, 2018, at 3:25 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> > @@ -4760,7 +4760,7 @@ static void test_showwindow(void)
> >     flush_sequence();
> >     ShowWindow(hwnd, SW_SHOWMAXIMIZED);
> >     ok_sequence(WmShowMaxPopupResizedSeq_todo,
> > -            "ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO", TRUE);
> > +            "ShowWindow(SW_SHOWMAXIMIZED):invisible maximized and resized popup TODO", FALSE);
>
> Should the name of the test sequence and the context string both have
> "_todo"/" TODO" removed? (Although "WmShowMaxPopupResizedSeq" is
> already used for a difference sequence.)

That would be better, yes, good point.

-- 
Alexandre Julliard
julliard(a)winehq.org