Re: [5/7] qmgr: Implement IBackgroundCopyJob::Cancel.

[Jacek Caban]

Hi Hans,

On 06/08/15 14:32, Hans Leidekker wrote:
> ---
>  dlls/qmgr/file.c |  1 +
>  dlls/qmgr/job.c  | 33 +++++++++++++++++++++++++++++++--
>  2 files changed, 32 insertions(+), 2 deletions(-)

I don't know qmgr, but shouldn't it result in IBinding::Abort() call on
underlying binding object?

Jacek

[5/7] qmgr: Implement IBackgroundCopyJob::Cancel.

[Hans Leidekker]

Hi Jacek,
> On 06/08/15 14:32, Hans Leidekker wrote:
> > ---
> >  dlls/qmgr/file.c |  1 +
> >  dlls/qmgr/job.c  | 33 +++++++++++++++++++++++++++++++--
> >  2 files changed, 32 insertions(+), 2 deletions(-)
>
> I don't know qmgr, but shouldn't it result in IBinding::Abort() call on
> underlying binding object?

Possibly. I don't claim it's a full implementation, I wrote enough of
it to make sure that files are cleaned up when running the tests. I'll
add a comment.

[5/7] qmgr: Implement IBackgroundCopyJob::Cancel.

[Jacek Caban]

On 06/08/15 16:37, Hans Leidekker wrote:
> Hi Jacek,
> > On 06/08/15 14:32, Hans Leidekker wrote:
> > > ---
> > >  dlls/qmgr/file.c |  1 +
> > >  dlls/qmgr/job.c  | 33 +++++++++++++++++++++++++++++++--
> > >  2 files changed, 32 insertions(+), 2 deletions(-)
> > > I don't know qmgr, but shouldn't it result in IBinding::Abort() call on
> > > underlying binding object?
> > > Possibly. I don't claim it's a full implementation, I wrote enough of
> > > it to make sure that files are cleaned up when running the tests. I'll
> > > add a comment.

It sounds more like a semi-stub for which FIXME() would be more
appropriate than a comment, IMHO.

Jacek