Any particular reason we are using printf in the shlwapi/istream tests?

[Paul Vriens]

Hi,

Should these printf's be turned into trace/skip?

-- 
Cheers,

Paul.

[Alexandre Julliard]

Paul Vriens <paul.vriens.wine(a)gmail.com> writes:
> Should these printf's be turned into trace/skip?

Yes.

-- 
Alexandre Julliard
julliard(a)winehq.org

[Paul Vriens]

Alexandre Julliard wrote:
> Paul Vriens <paul.vriens.wine(a)gmail.com> writes:
> > Should these printf's be turned into trace/skip?
>
> Yes.

Just sent in a patch for that.

Doing a quick (probably some false positives as well) gives:

comctl32/tests/imagelist.c
comctl32/tests/rebar.c
comctl32/tests/toolbar.c
crypt32/tests/encode.c
crypt32/tests/store.c
cryptnet/tests/cryptnet.c
gdi32/tests/dc.c
gdi32/tests/metafile.c
hlink/tests/hlink.c
imm32/tests/imm32.c
kernel32/tests/comm.c
kernel32/tests/file.c
kernel32/tests/format_msg.c
msi/tests/package.c
msvcrt/tests/printf.c
msvcrt/tests/string.c
msvcrt/tests/testlist.c
msvcrt/tests/time.c
ole32/tests/moniker.c
oleaut32/tests/typelib.c
rpcrt4/tests/rpc.c
rsaenh/tests/rsaenh.c
shell32/tests/shellpath.c
shell32/tests/shlexec.c
user32/tests/msg.c

that also have printf's in them. So another janitorial task?

-- 
Cheers,

Paul.