[PATCH][RFC] winemine: Add message context to advanced difficulty string

[Julian Rüger]

Hi everyone,

as I explained in my previous mail "Translation problem with oledb32",
the winemine difficulty and the oledb32 ADO dialog tab both share the
same po string "Advanced". That is problematic for at least the German
translation. (I wonder if that is the only one, I'd guess not, though I
don't speak any other language nearly well enough to judge)


I decided to add a message context to winemine and not to oledb32, since
winemine is the odd one out in this case, while potentially in the
future, other "Advanced" strings would likely have the same translation
as oledb32.

I'd love to hear some suggestions/opinions on what would be the best way
to handle this.


1. Should I add a similar message context to the "Beginner" and "Expert"
difficulties as well, to keep it consistent even when there are no
collisions (yet)?
2. There are two strings for each difficulty, for the file menu
"&Beginner", "&Advanced", ... Add message contexts for these?
3. Avoid this whole thing by changing the winemine string to
"Intermediate"?

My personal feeling is 1. makes sense, 2. probably not, 3. easiest,
cleanest solution but changes the tone, do people care?



Also please point out any other issues with the patch.


Thanks in advance for your input!

Best,
Julian

[Alexandre Julliard]

Julian Rüger <jr98(a)gmx.net> writes:
> 1. Should I add a similar message context to the "Beginner" and "Expert"
> difficulties as well, to keep it consistent even when there are no
> collisions (yet)?
> 2. There are two strings for each difficulty, for the file menu
> "&Beginner", "&Advanced", ... Add message contexts for these?
> 3. Avoid this whole thing by changing the winemine string to
> "Intermediate"?
>
> My personal feeling is 1. makes sense, 2. probably not, 3. easiest,
> cleanest solution but changes the tone, do people care?

"Intermediate" sounds fine to me.

-- 
Alexandre Julliard
julliard(a)winehq.org