Re: [PATCH 4/4] wined3d: Always use screen-sized frontbuffers.

[Henri Verbeet]

On 6 July 2015 at 23:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> ---
>  dlls/wined3d/device.c    |  6 +++---
>  dlls/wined3d/surface.c   | 22 +++++++++++++++++-----
>  dlls/wined3d/swapchain.c | 27 +++++++++++++--------------
>  3 files changed, 33 insertions(+), 22 deletions(-)

Why would we want that?

[PATCH 4/4] wined3d: Always use screen-sized frontbuffers.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-07-07 um 16:59 schrieb Henri Verbeet:
> Why would we want that?
> Currently the WGL -> sysmem copy code assumes window size == surface
> size. That's OK because it is only hit by GetFrontBufferData. The
> texture<->WGL blit code assumes the surface size is the screen size.
> It is only called by ddraw with pre-clipped coordinates, so that's OK
> in practice. But overall this is a mess.

Things will be a lot more tricky when the ddraw shadow frontbuffer
goes away and ddraw blits and GetFrontBufferData run through the same
codepaths. Always having the frontbuffer window sized isn't an option
for ddraw.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVnCTWAAoJEN0/YqbEcdMwOdkP/RZw426dYft7nfE6FK1T2btK
d3KPq0V+0WxLufIz6J86WduODJXHUW7ckEVBXdrXpdMiTsgi2sZo0Bq2GWpvFniX
dxmGnIPfuAx9IlGa/cS2mqf4V/2xSalLYdysA3xXHQrcOiELSnMDf49eeOlDX19N
wrhZkS+5PCVBt5FXEtIjhptEXYCeVJEd67M9TDw8lsM8nF0ETY6TZ5DB4sDTI0u2
J5hQjxfd6LYn0Ld5M/ohs4OiRC+Qpzm/tMAF+VAbu13dYEwZBDVNsDCZnnr5BytO
0kyQRaCY1nbnWjuAkmHZQXU+nJ1HThwx9RfsfFGHjVFhFbl+hngU54YQu+PJJqSh
oHE69itpDa0+NTJQp+8902hzHdkQBGIJ1Qd89Rq79VDawI+njRTKCVdH0QoL4nUu
d3Nj7xbpj1AHJCSLcChRPoqQivh1ZXeGAjMohSq0niDVb19K5pl3JI08CWIu0dFb
VeIjP7E+BEquM7UOxszirlZZI3YvSNf0ys7RjA80l7gbgMPNDnl+8C2OWCR0JMbM
63315TdsKgpahFpqoKUErbPJN7HnTTFOiu7s/cKALifodXOzmHYK973IAOq4Xxmm
xG2jpSP09x9/yQI+FVvzkGZ3XMXCCOdHY84qAokl9WfQf+71r/DaFCslh4+8F9wH
g/uxcUBHo3wbHjHqTT/o
=9seo
-----END PGP SIGNATURE-----